Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #54

Closed
wants to merge 1 commit into from
Closed

Docker support #54

wants to merge 1 commit into from

Conversation

Coronon
Copy link
Contributor

@Coronon Coronon commented Jan 17, 2022

This commit adds docker support to smtprelay.

I needed to run this between an isolated network and the hostile interwebs inside docker-compose, so after a bit of tinkering, this came about.

Please just review but don't merge yet, as I want to battle test this first :)

@JonathonReinhart
Copy link
Collaborator

Thanks for the contribution, but #50 was already closed.

@Coronon
Copy link
Contributor Author

Coronon commented Jan 17, 2022

@JonathonReinhart There is a big difference: #50 wanted to automatically push to the public docker registry after each build. This only adds the ability to create your own image. As it is build directly always from the latest version by the user after clone, there isn't much "maintaining".

@decke
Copy link
Owner

decke commented Jan 18, 2022

@Coronon I do understand that people want to run smtprelay in a docker environment and I have no problems with that. I also plan to rewrite the config part in smtprelay to use peterbourgon/ff which now also supports .env files and environment variables. That should ease life in docker environments.

But I do not plan to provide any default Dockerfiles or prepared images. From what I have seen the people that want to run it in a docker environment are all capable of doing that since it's a straight forward Go project. The Dockerfiles that I have seen for smtprelay are all biased in some way and differ from what I would do. If someone thinks it's necessary then please create some unofficial docker image for your own use case like it seems to be common in this environments. Please also respect that I will not recommend any of those over any other.

@Coronon
Copy link
Contributor Author

Coronon commented Jan 18, 2022

@decke Fair enough, still huge thanks for this awesome tool!

@decke decke mentioned this pull request Aug 16, 2022
This was referenced Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants