Delete New*SetFromSlice() and NewSetWith() APIs
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2022
jeffwidman
changed the title
New*SetFromSlice() and NewSetWith() APIs
|
@jeffwidman - thanks for these contributions, I merged your previous change and this one is showing merge conflicts. Would you be up to resolving the merge conflicts and then I'll do a merge? |
These are no longer needed now that both `NewSet()` and `NewThreadUnsafeSet()` accept optional vals. Removing them simplifies the API surface, so that developers aren't left scratching their heads wondering why there's both a `NewSet(vals ...T)` and a `NewSetFromSlice()` that do the same thing. Previously they couldn't be removed due to backwards compatibility concerns, but with the `go 1.18` drop of generics, this library will be cutting a new `v2` release, so a perfect time to cleanup this confusing API as well.
|
Thanks @deckarep, I just rebased to fix the merge conflicts. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #83 , that should be merged first, then this.
These are no longer needed now that both
NewSet()andNewThreadUnsafeSet()accept optional vals.Removing them simplifies the API surface, so that developers aren't left
scratching their heads wondering why there's both a
NewSet(vals ...T)and a
NewSetFromSlice()that do the same thing.Previously they couldn't be removed due to backwards compatibility
concerns, but with the
go 1.18drop of generics, this library will becutting a new
v2release, so a perfect time to cleanup this confusingAPI as well.
Fix #78