Syncrhonize chrome and chrome-driver versions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverbarnes
suggested changes
Nov 19, 2020
| @@ -17,7 +17,7 @@ RUN curl -sL https://deb.nodesource.com/setup_10.x | bash - \ | |||
|
|
|||
| RUN npm install -g [email protected] | |||
|
|
|||
| RUN gem install bundler \ | |||
| RUN gem install bundler --version '>= 2.1.4' \ | |||
There was a problem hiding this comment.
Is this needed if it'll build with ruby > 2.6, which comes with bundler built in?
There was a problem hiding this comment.
I added it because I was getting an error on the bundler version because it was something like 1.17...
There was a problem hiding this comment.
Ahh, I see - it comes with an older version :/ I double checked now and it is indeed at 1.17.2:
➜ decidim-docker git:(sandbox) docker run --name ruby -i -t ruby:2.6.6 bash
root@2ce5d8d66e46:/# ruby -v
ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-linux]
root@2ce5d8d66e46:/# bundle -v
Bundler version 1.17.2
oliverbarnes
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome and chrome driver versions have diverged.
This PR synchronizes both in the
Dockerfile-test.