Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimistic ui for comments #987

Merged
merged 2 commits into from
Feb 16, 2017
Merged

Conversation

beagleknight
Copy link
Contributor

🎩 What? Why?

There was a small issue when creating a comment and the list of comments disappears briefly. It was caused by a small bug on the optimistic ui which was missing a field.

I also reimplemented the add comment form validation using only react because it was causing a false input error when adding a comment.

📌 Related Issues

📋 Subtasks

None

📷 Screenshots (optional)

None

👻 GIF

None

@mention-bot
Copy link

@beagleknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lastpotion and @josepjaume to be potential reviewers.

@beagleknight beagleknight force-pushed the fix/comments/optimistic-ui branch from b816248 to 9359b38 Compare February 16, 2017 11:56
@codecov-io
Copy link

codecov-io commented Feb 16, 2017

Codecov Report

Merging #987 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   97.17%   97.18%   +<.01%     
==========================================
  Files         385      385              
  Lines        6345     6358      +13     
==========================================
+ Hits         6166     6179      +13     
  Misses        179      179
Impacted Files Coverage Δ
decidim-core/app/helpers/decidim/layout_helper.rb 55.17% <ø> (-5.44%)
...cidim-core/lib/decidim/features/base_controller.rb 100% <ø> (ø)
...cidim-core/app/helpers/decidim/meta_tags_helper.rb 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e2de2...9359b38. Read the comment docs.

@josepjaume josepjaume merged commit 6d72d88 into master Feb 16, 2017
@josepjaume josepjaume deleted the fix/comments/optimistic-ui branch February 16, 2017 12:21
Quentinchampenois added a commit to Quentinchampenois/decidim that referenced this pull request Nov 12, 2020
* fix tests support_count sort in BO

* rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants