Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce normalizing locales #94

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Conversation

josepjaume
Copy link
Contributor

@josepjaume josepjaume commented Oct 11, 2016

🎩 What? Why?

In order to prevent conflicts when merging branches with potentially lots of translations, it's a good habit to have your locales normalized. This adds a spec that enforces exactly that.

🎯 Acceptance criteria?

Change your locales, run the specs.

👻 GIF

@codecov-io
Copy link

codecov-io commented Oct 11, 2016

Current coverage is 96.86% (diff: 100%)

Merging #94 into master will not change coverage

@@             master        #94   diff @@
==========================================
  Files           128        128          
  Lines          1657       1657          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1605       1605          
  Misses           52         52          
  Partials          0          0          

Powered by Codecov. Last update f8c6b37...a1cf17a

@josepjaume josepjaume merged commit f1b8d36 into master Oct 13, 2016
@oriolgual oriolgual deleted the enforce_normalizing_locales branch October 13, 2016 13:58
alecslupu added a commit to alecslupu/decidim that referenced this pull request Nov 20, 2021
…-block-user-justification

Display error message in case that justification length is less than …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants