Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Duplicate branch' lint offense in budgets #9306

Closed
wants to merge 1 commit into from

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

There's a CI flow failing in develop for some changes done Friday, regarding the changes to Rubocop configuration and a new feature in Budgets (#8986).

Offenses:

decidim-budgets/app/permissions/decidim/budgets/admin/permissions.rb:26:13: W: Lint/DuplicateBranch: Duplicate branch body detected.
when :project_category ...
^^^^^^^^^^^^^^^^^^^^^^
decidim-budgets/app/permissions/decidim/budgets/admin/permissions.rb:36:11: W: Lint/DuplicateBranch: Duplicate branch body detected.
when :project_scope ...
^^^^^^^^^^^^^^^^^^^
decidim-budgets/app/permissions/decidim/budgets/admin/permissions.rb:38:11: W: Lint/DuplicateBranch: Duplicate branch body detected.
when :project_selected ...
^^^^^^^^^^^^^^^^^^^^^^

This PR fixes it.

(It's difficult to detect this before merging. We could ask for people to merge when we do this kind of changes, but that could be too cumbersome/with little value and we of course can always fix it after, as this PR).

📌 Related Issues

Testing

"[CI] Lint code" should be passing/green.

♥️ Thank you!

@andreslucena andreslucena added module: budgets type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels May 16, 2022
@andreslucena
Copy link
Member Author

Mind that there's still a failing spec that will be fixed when #9307 is merged

@andreslucena
Copy link
Member Author

Already fixed by #9305, closing this

@andreslucena andreslucena deleted the test/fix-rubocop-budgets-permissions branch May 16, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: budgets type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant