Fix for endorsed_by with other user group's member #8967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When a user group has endorsed a resource (for instance, a proposal) and another member of the user group with permissions go to unendorse it, they cannot do that.
This PR fixes that.
I've also improved the specs by moving the endorsable examples to a shared example for better reusing without copying and pasting.
📌 Related Issues
Testing
📷 Screenshots
Before
After