Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for endorsed_by with other user group's member #8967

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

When a user group has endorsed a resource (for instance, a proposal) and another member of the user group with permissions go to unendorse it, they cannot do that.

This PR fixes that.

I've also improved the specs by moving the endorsable examples to a shared example for better reusing without copying and pasting.

📌 Related Issues

Testing

  1. Add two participants to the same user group with "admin" role
  2. Go to a proposal, endorse it as user group with one user
  3. Open another browser, sign in with other user, go to endorse the same proposal
  4. See that your user group isn't selected, and you can't unendorse it

📷 Screenshots

Before

image

After

image

♥️ Thank you!

@andreslucena andreslucena merged commit 5fd3841 into develop Mar 9, 2022
@andreslucena andreslucena deleted the fix/user-groups-unendorse branch March 9, 2022 10:00
@andreslucena andreslucena self-assigned this Mar 22, 2022
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants