Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illogical heading order for the versions list #8880

Merged

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Feb 22, 2022

🎩 What? Why?

The versions list items order is illogical.

Take a look e.g. at this page:
https://meta.decidim.org/processes/roadmap/f/122/proposals/16942/versions

After the "Versions" heading, the heading jumps from h3 -> h6.

WCAG 2.2 / 1.3.1 Info and Relationships (Level A)

https://www.w3.org/TR/WCAG22/#info-and-relationships
https://www.w3.org/WAI/WCAG22/Understanding/info-and-relationships.html

Testing

Give the linked versions page to a visually impaired user and ask them to read it.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug labels Feb 23, 2022
@andreslucena andreslucena merged commit 2e82139 into decidim:develop Feb 23, 2022
@andreslucena
Copy link
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@ahukkanen ahukkanen deleted the fix/version-list-item-heading-level branch February 23, 2022 14:56
ahukkanen added a commit to mainio/decidim that referenced this pull request Mar 2, 2022
@ahukkanen
Copy link
Contributor Author

Backport at #8950.

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core team: accessibility type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants