Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some non-localized user emails #8719

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Jan 17, 2022

🎩 What? Why?

Currently there are some emails that are not being translated depending on the user preference. This PR fixes this issue.

Testing

Set the default organization locale to a language. Choose an user, set the locale in some other language. Trigger the events that are issuing those emails. You should receive them in user's (recipient's) language.

♥️ Thank you!

@alecslupu alecslupu requested a review from roxanaopr January 17, 2022 08:01
@alecslupu alecslupu changed the title Localize user mails Localize user emails Jan 17, 2022
@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label Jan 17, 2022
@andreslucena andreslucena changed the title Localize user emails Fix some non-localized user emails Jan 17, 2022
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@andreslucena andreslucena merged commit b535c6f into decidim:develop Jan 17, 2022
@andreslucena
Copy link
Member

Can you please backport to v0.26-stable 🙏🏽? Thanks

@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
@alecslupu alecslupu deleted the fix/mailer-translations branch October 31, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants