Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not let process admins manage users #729

Merged
merged 2 commits into from
Feb 1, 2017

Conversation

mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Feb 1, 2017

🎩 What? Why?

Process admins should not be able to manage admins. No link appears in the sidebar. Trying to access the section via URL redirects the user to the admin dashboard.

📌 Related Issues

📋 Subtasks

None

📷 Screenshots (optional)

Description

@mention-bot
Copy link

@mrcasals, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oriolgual and @josepjaume to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Feb 1, 2017

Codecov Report

Merging #729 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   97.13%   97.13%   +<.01%     
==========================================
  Files         339      339              
  Lines        5404     5406       +2     
==========================================
+ Hits         5249     5251       +2     
  Misses        155      155
Impacted Files Coverage Δ
.../app/controllers/decidim/admin/users_controller.rb 90.47% <100%> (ø)
...dim/admin/abilities/participatory_process_admin.rb 100% <100%> (ø)
...n/app/models/decidim/admin/abilities/admin_user.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a366a4...5775029. Read the comment docs.

@oriolgual oriolgual merged commit b3df4d6 into master Feb 1, 2017
@oriolgual oriolgual deleted the fix_process_admin_abilities branch February 1, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants