Fix double requests for filters #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepjaume
approved these changes
Jan 25, 2017
mrcasals
approved these changes
Jan 26, 2017
Current coverage is 97.28% (diff: 100%)
|
Current coverage is 97.28% (diff: 100%)
|
This was referenced Jan 26, 2017
Merged
beagleknight
force-pushed
the
fix/double-filters
branch
from
ccb15bb to
eb919aa
Compare
beagleknight
force-pushed
the
fix/double-filters
branch
from
eb919aa to
99e2d9d
Compare
beagleknight
force-pushed
the
fix/double-filters
branch
from
99e2d9d to
a58ac2a
Compare
oriolgual
approved these changes
Jan 26, 2017
josepjaume
approved these changes
Jan 26, 2017
beagleknight
force-pushed
the
fix/double-filters
branch
from
a58ac2a to
d8aa8b2
Compare
mrcasals
approved these changes
Jan 26, 2017
beagleknight
added a commit
that referenced
this pull request
Jan 26, 2017
* Fix double requests * Apply form filter to each form * Update docs * Don't generate id for filter form * Fix broken specs
oriolgual
pushed a commit
that referenced
this pull request
Jan 26, 2017
* Fix double requests * Apply form filter to each form * Update docs * Don't generate id for filter form * Fix broken specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix the double requests in filters caused by including the
filters_form_fortwice.📌 Related Issues
📋 Subtasks
None
📷 Screenshots (optional)
None
👻 GIF
None