Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov #502

Merged
merged 2 commits into from
Jan 14, 2017
Merged

Fix codecov #502

merged 2 commits into from
Jan 14, 2017

Conversation

josepjaume
Copy link
Contributor

@josepjaume josepjaume commented Jan 13, 2017

🎩 What? Why?

This tries to fix codecov's reports while also including tests (and it makes sense)

📌 Related Issues

None

📋 Subtasks

None

📷 Screenshots (optional)

None

👻 GIF

@mention-bot
Copy link

@josepjaume, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oriolgual, @mrcasals and @beagleknight to be potential reviewers.

@josepjaume josepjaume force-pushed the fix_codecov branch 2 times, most recently from e24cf88 to a75ec04 Compare January 13, 2017 14:09
@codecov-io
Copy link

codecov-io commented Jan 13, 2017

Current coverage is 96.72% (diff: 100%)

Merging #502 into master will increase coverage by 36.30%

@@             master       #502   diff @@
==========================================
  Files          2825        239     -2586   
  Lines        120838       3603   -117235   
  Methods           0          0             
  Messages          0          0             
  Branches          0          0             
==========================================
- Hits          73013       3485    -69528   
+ Misses        47825        118    -47707   
  Partials          0          0             

Powered by Codecov. Last update 3eaacdb...5e59804

@oriolgual oriolgual merged commit c3da8f8 into master Jan 14, 2017
@oriolgual oriolgual deleted the fix_codecov branch January 14, 2017 11:35
aitorlb pushed a commit to CodiTramuntana/decidim that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants