Fix comment's created at wrong timezone #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beagleknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @josepjaume to be a potential reviewer. |
beagleknight
requested review from
oriolgual,
josepjaume,
mrcasals,
divins,
lastpotion and
ItsGenis
mrcasals
approved these changes
Jan 9, 2017
josepjaume
previously requested changes
Jan 9, 2017
| @@ -12,7 +12,7 @@ const generateCommentsData = (num = 1) => { | |||
| commentsData.push({ | |||
| id: random.uuid(), | |||
| body: random.words(), | |||
| createdAt: date.past().toString(), | |||
| createdAt: Math.floor(date.past().getTime() / 1000), | |||
There was a problem hiding this comment.
I'd use ISO8901 format instead. Should work seamlessly with moment.parse.
beagleknight
force-pushed
the
fix/comment-created-at-timezone
branch
from
89f2589 to
5e3c9ca
Compare
Current coverage is 96.93% (diff: 100%)@@ master #460 diff @@
==========================================
Files 234 234
Lines 3527 3528 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3419 3420 +1
Misses 108 108
Partials 0 0
|
beagleknight
force-pushed
the
fix/comment-created-at-timezone
branch
from
aedb269 to
e16b9be
Compare
oriolgual
suggested changes
Jan 10, 2017
| @@ -11,7 +11,9 @@ module Comments | |||
| field :body, !types.String, "The comment message" | |||
|
|
|||
| field :createdAt, !types.String, "The creation date of the comment" do | |||
| property :created_at | |||
| resolve lambda { |obj, _args, _ctx| | |||
| obj.created_at.to_time.iso8601 | |||
There was a problem hiding this comment.
Why do you need to time? Wouldn't it be better to use seconds from epoch?
There was a problem hiding this comment.
I'm not really sure... I found that as an example but I think I can use the iso8601 method directly.
lastpotion
approved these changes
Jan 10, 2017
oriolgual
approved these changes
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Comment component was rendering the
createdAtwith an incorrect timezone.📌 Related Issues
📋 Subtasks
None
📷 Screenshots (optional)
None
👻 GIF