Consultations: unify navigation

[mrcasals]

🎩 What? Why?

This PR overhauls the navigation for decidim-consultations, as I find it very hard to understand, by doing this:

• The topbar link to Consultations used to take to the active consultation, if only 1. Now it always takes to the index page, as you might want to see the past or upcoming consultations. This is consistent to the other navigations.
• Uses the consultation card in the index page
• In the consultation page, there were two lists: "Highlighted consultations" and "Other consultations". The first one is now called "Highlighted questions", since that's what it's listing. The last one is now called "Questions for this consultations" and lists all questions for the current consultation. This is to avoid a weird title when no highlighted questions were found for the given consultation, and we had the "Other consultations" text, which was very weird to me.
• Removes the "finished consultations" view. It was only listing finished and active ones, but was missing the upcoming ones. This is now superseded by the filtered index page.

📌 Related Issues

• Closes Can't check finished consultations #3482

📋 Subtasks

• Add CHANGELOG entry

📷 Screenshots (optional)

Index page:

Show page:

[mrcasals]

@decidim/product thoughts on this?

[andreslucena]

The topbar link to Consultations used to take to the active consultation, if only 1. Now it always takes to the index page, as you might want to see the past or upcoming consultations. This is consistent to the other navigations.

I'm not so sure about this one. I'd prefer to have this kind of logic, but also for other kind of contents (for instance, when there's only a participatory process or only an assembly). This kind of use case (Decidim with Only 1 Participatory Process) is pretty common, and to display /processes when there is only one it's unnecessary for me.

But I'd love to hear thoughts from the rest of @decidim/product

[mrcasals]

@andreslucena I'm not really for this kind of navigations, to me a link should always take you to the same place consistently, and if I click a link called "Consultations" (in plural), I expect it to take me to the index page, but I see your point. The problem with the previous navigation for consultations (the one in master) is that, in the case when there's only one active consultation, but many finished and upcoming, there was no way to see the upcoming ones. The topbar link takes you to the active page, and from there you could visit a page where the finished and active ones were listed. But there was no way to see the upcoming ones. This was a problem to my while trying to debug #3457

[josepjaume]

For consistency reasons, I think we should merge this in. If we are to rethink the way navigation works when dealing with collections, we should discuss it with @decidim/web-design and unify it.

[mrcasals]

Build is green, conflicts were only on the CHANGELOG file and this PR was approved.

I'm merging this for consistency reasons. We can open a new issue discussing any change on navigation patterns for the platform if anyone thinks it's needed.