Issue #212 - When switching tabs in i18n fields, autofocus on the inp… #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the input to save clicks
|
@RedRudeBoy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mrcasals and @beagleknight to be potential reviewers. |
josepjaume
suggested changes
Nov 26, 2016
There was a problem hiding this comment.
Hi! Thanks for your contribution! It looks like eslint trolled you a bit about the implementation style.
You can probably use eslint --fix to auto-fix most of those issues though.
Current coverage is 97.41% (diff: 100%)@@ master #284 diff @@
==========================================
Files 288 288
Lines 4918 4918
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4791 4791
Misses 127 127
Partials 0 0
|
josepjaume
approved these changes
Nov 28, 2016
oriolgual
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When switching tabs in i18n fields, autofocus on the input to save clicks
📌 Related Issues
👻 GIF