Let engines mount themselves #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josepjaume, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oriolgual, @beagleknight and @mrcasals to be potential reviewers. |
josepjaume
force-pushed
the
let_engines_mount_themselves
branch
from
17dcf72 to
ec7053c
Compare
oriolgual
suggested changes
Nov 17, 2016
josepjaume
force-pushed
the
let_engines_mount_themselves
branch
from
ec7053c to
dcda8e5
Compare
Current coverage is 97.48% (diff: 33.33%)@@ master #247 diff @@
==========================================
Files 270 270
Lines 4489 4496 +7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4380 4383 +3
- Misses 109 113 +4
Partials 0 0
|
beagleknight
approved these changes
Nov 17, 2016
mrcasals
approved these changes
Nov 17, 2016
josepjaume
force-pushed
the
let_engines_mount_themselves
branch
from
fa20e53 to
6a07a1b
Compare
|
@AjuntamentdeBarcelona/developers you'll have to re-create your development and test apps after this. |
oriolgual
approved these changes
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We've all felt the pain of our development apps becoming outdated as we keep adding more engines - normally because you might need to add a new mount point in your
routes.rb. This PR deals with it letting the engines mount themselves againstDecidim::Core::Engineand makingDecidim::Core::Enginethe only mount point of the app.📌 Related Issues
None
📋 Subtasks
None
📷 Screenshots (optional)
None
👻 GIF