Limit proposals per user #2069
Merged
Limit proposals per user #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #2069 +/- ##
==========================================
- Coverage 98.55% 98.55% -0.01%
==========================================
Files 1174 1174
Lines 26691 26752 +61
==========================================
+ Hits 26306 26365 +59
- Misses 385 387 +2 |
josepjaume
force-pushed
the
feature/limit_proposals_per_user
branch
from
73c747c to
fb73142
Compare
mrcasals
reviewed
Oct 19, 2017
| @@ -87,6 +87,10 @@ def default_filter_params | |||
| related_to: "" | |||
| } | |||
| end | |||
|
|
|||
| def check_proposal_limit! | |||
| raise "Proposal limit reached" if proposal_limit_reached? | |||
There was a problem hiding this comment.
raise? Can we make it redirect to the index with a flash message or something?
mrcasals
previously approved these changes
Oct 19, 2017
mrcasals
approved these changes
Oct 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As defined in #1356, this adds a setting to limit the amount of proposals a user can submit.
📌 Related Issues
📋 Subtasks
None
📷 Screenshots (optional)
None
👻 GIF