Fix default button when no voting enabled #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the tests here don't need all the object creations in the global setup. So move that only where it's needed. This makes the tests faster, but more importantly it makes it easier to understand them and add new ones, since you don't have to go up 600 lines to see which objects are created by each tests, and thus which expectations to set.
Through specific attribute and not only CSS.
deivid-rodriguez
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 94.97% 95.49% +0.52%
==========================================
Files 416 436 +20
Lines 7163 7502 +339
==========================================
+ Hits 6803 7164 +361
+ Misses 360 338 -22 |
mrcasals
reviewed
Jun 1, 2017
| @@ -120,6 +120,8 @@ ca: | |||
| most_voted: Més votat | |||
| random: Aleatori | |||
| recent: Recent | |||
| proposal: | |||
| view_proposal: Veure proposta | |||
There was a problem hiding this comment.
We shouldn't be adding locales directly from a PR, we should only do this via Crowdin
There was a problem hiding this comment.
Sorry, git revert tricked me!
josepjaume
approved these changes
Jun 1, 2017
There was a problem hiding this comment.
Nicely done! It also proved my reviewing skills are not that good either.
As @mrcasals said, we should be adding translations via Crowdin, otherwise I believe they're just getting swallowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
In previous PR (#1427), I accidentally removed some used logic, proving that my prepositional logic skills are a bit rusty 😅. In particular, I removed the "View proposal" link that appears instead of the "Vote" button when voting is not enabled.
This PR restores that, backs it up with tests, and improves and adds some other tests and code around proposal listing.
📌 Related Issues
📋 Subtasks
None.
📷 Screenshots (optional)
None.
👻 GIF