Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse #role? method from User model #1391

Merged
merged 1 commit into from
May 23, 2017
Merged

Reuse #role? method from User model #1391

merged 1 commit into from
May 23, 2017

Conversation

deivid-rodriguez
Copy link
Contributor

🎩 What? Why?

Reuse a method instead of rewriting it.

📌 Related Issues

None.

📋 Subtasks

None.

📷 Screenshots (optional)

None.

👻 GIF

armadillo

@codecov
Copy link

codecov bot commented May 22, 2017

Codecov Report

Merging #1391 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1391   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         421      421           
  Lines        7212     7212           
=======================================
  Hits         6884     6884           
  Misses        328      328
Impacted Files Coverage Δ
.../controllers/decidim/devise/sessions_controller.rb 92.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7923248...8c02cb7. Read the comment docs.

Copy link
Contributor

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL thanks, well spotted!

@josepjaume josepjaume merged commit a5584e3 into decidim:master May 23, 2017
@deivid-rodriguez deivid-rodriguez deleted the dry_up branch May 23, 2017 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants