Update create participatory process command. #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastpotion
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
=========================================
- Coverage 95.47% 95.17% -0.3%
=========================================
Files 420 393 -27
Lines 7202 6825 -377
=========================================
- Hits 6876 6496 -380
- Misses 326 329 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
==========================================
- Coverage 95.47% 95.41% -0.06%
==========================================
Files 420 410 -10
Lines 7202 7086 -116
==========================================
- Hits 6876 6761 -115
+ Misses 326 325 -1
Continue to review full report at Codecov.
|
mrcasals
approved these changes
May 10, 2017
alecslupu
added a commit
to tremend-cofe/decidim
that referenced
this pull request
Nov 28, 2020
tramuntanal
pushed a commit
that referenced
this pull request
Dec 15, 2020
* Adding Types to graphql * GraphQL api syntax for Decidim, HashTag, Organization, Scalar Refactory * Using deprecated DSL to avoid ! issues (graphql - #1334) * Fix failing tests * Linters * Update decidim-api/lib/decidim/api/test/type_context.rb Co-authored-by: Ivan Vergés <[email protected]> * Update decidim-core/lib/decidim/core/engine.rb Co-authored-by: Ivan Vergés <[email protected]> * Use full Namespace for GraphQL types Co-authored-by: Ivan Vergés <[email protected]>
tramuntanal
pushed a commit
that referenced
this pull request
Dec 30, 2020
* Adding Types to graphql * GraphQL api syntax for Decidim, HashTag, Organization, Scalar Refactory * Using deprecated DSL to avoid ! issues (graphql - #1334) * Fix failing tests * Linters * Adding tests for accountability * Adding blogs integration tests * Partial work on budgets * Update sortition_type.rb * Add more tests for other components * Update decidim-api/lib/decidim/api/test/type_context.rb Co-authored-by: Ivan Vergés <[email protected]> * Update decidim-core/lib/decidim/core/engine.rb Co-authored-by: Ivan Vergés <[email protected]> * Linters on the project * Fixing failing tests * Fix failing tests * Attept to fix failing tests * Attempting to fix failing test * Fixing tests * Refactor the tests * Breaking the assertion to understand why is failing * Breaking the assertion to understand why is failing * Attempting to fix test * Attempting to fix test * Adding tests for assemblies, conferences, consultations, initiatives * Initiative type integration test + linting * Enhance test on survey * Lint tests Co-authored-by: Ivan Vergés <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When an user creates a new PP as an admin, some of the optional fields weren't saved properly with the
create_participatory_processcommand.This PR updates this attribute list to solve the issue, fixes the redirect_to and add
map_modelmethod to the respective form to fix some rendering issues.📌 Related Issues
📷 Screenshots (optional)
👻 GIF