Fix admin navigation for mobile devices #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrcasals, thanks for your PR! By analyzing the history of the files in this pull request, we identified @beagleknight and @lastpotion to be potential reviewers. |
oriolgual
approved these changes
Apr 10, 2017
mrcasals
force-pushed
the
fix_admin_mobile_nav
branch
from
8b65842 to
ca635d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1251 +/- ##
=======================================
Coverage 97.04% 97.04%
=======================================
Files 424 424
Lines 7148 7148
=======================================
Hits 6937 6937
Misses 211 211Continue to review full report at Codecov.
|
mrcasals
force-pushed
the
fix_admin_mobile_nav
branch
from
ca635d7 to
e0637e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Admin navigation is broken on mobile devices, the hamburger menu does not do anything. This PR adds a missing JS file that toggles the navigation for mobile devices, thus making the hamburger menu work.
📌 Related Issues
📋 Subtasks
None