Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Waffle badges #1121

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Update Waffle badges #1121

merged 1 commit into from
Mar 15, 2017

Conversation

mrcasals
Copy link
Contributor

🎩 What? Why?

After last Waffle reordering, we were missing the badge for the Planned column. This PR replaces the old Ready one for the Planned one.

📌 Related Issues

None

📋 Subtasks

None

@mention-bot
Copy link

@mrcasals, thanks for your PR! By analyzing the history of the files in this pull request, we identified @josepjaume and @beagleknight to be potential reviewers.

@mrcasals mrcasals self-assigned this Mar 15, 2017
Copy link
Contributor

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, damn! Thanks.

@josepjaume
Copy link
Contributor

No need to wait for tests here.

@josepjaume josepjaume merged commit 587ca4b into master Mar 15, 2017
@josepjaume josepjaume deleted the mrcasals-patch-1 branch March 15, 2017 07:46
@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #1121 into master will decrease coverage by 2.29%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1121     +/-   ##
=========================================
- Coverage   97.16%   94.86%   -2.3%     
=========================================
  Files         413      326     -87     
  Lines        6912     5454   -1458     
=========================================
- Hits         6716     5174   -1542     
- Misses        196      280     +84
Impacted Files Coverage Δ
decidim-core/app/helpers/decidim/map_helper.rb 25% <0%> (-75%)
...m-comments/lib/decidim/comments/comments_helper.rb 40% <0%> (-60%)
...ntrollers/concerns/decidim/action_authorization.rb 47.82% <0%> (-43.48%)
...models/decidim/proposals/abilities/current_user.rb 61.9% <0%> (-38.1%)
...esolvers/decidim/comments/vote_comment_resolver.rb 66.66% <0%> (-33.34%)
...ecidim-budgets/app/models/decidim/budgets/order.rb 68.75% <0%> (-31.25%)
...ypes/decidim/comments/commentable_mutation_type.rb 70.58% <0%> (-29.42%)
...cidim-comments/lib/decidim/comments/commentable.rb 70.58% <0%> (-29.42%)
decidim-api/lib/decidim/api/schema.rb 75% <0%> (-25%)
decidim-core/lib/decidim/feature_validator.rb 75% <0%> (-25%)
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71851e4...bd8fd37. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants