Add append info to payload #1109
Conversation
| super | ||
| payload[:user_id] = try(:current_user).try(:id) | ||
| payload[:organization_id] = try(:current_organization).try(:id) | ||
| payload[:app] = try(:current_organization).name |
There was a problem hiding this comment.
I don't think we need try in any of these cases
| @@ -9,6 +9,18 @@ class ApplicationController < ActionController::Base | |||
| helper Decidim::TranslationsHelper | |||
| helper Decidim::DecidimFormHelper | |||
| helper Decidim::ReplaceButtonsHelper | |||
|
|
|||
| def append_info_to_payload(payload) | |||
There was a problem hiding this comment.
This method needs to be in all base/top controllers. Extract it to a concern.
There was a problem hiding this comment.
Why not move it to Decidim::ApplicationController? I think everything inherits from this one.
There was a problem hiding this comment.
@mrcasals Admin & System inherit from ActionController::Base
ItsGenis
force-pushed
the
feature/json-logs
branch
2 times, most recently
from
8c03542 to
408dad3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
+ Coverage 97.17% 97.18% +<.01%
==========================================
Files 413 414 +1
Lines 6912 6930 +18
==========================================
+ Hits 6717 6735 +18
Misses 195 195
Continue to review full report at Codecov.
|
| def append_info_to_payload(payload) | ||
| super | ||
| payload[:user_id] = current_user.try(:id) | ||
| payload[:organization_id] = current_organization.try(:id) |
| def append_info_to_payload(payload) | ||
| super | ||
| payload[:user_id] = current_user.try(:id) | ||
| payload[:organization_id] = current_organization.try(:id) |
|
I understood we want it removed from our conversation offline. |
ItsGenis
force-pushed
the
feature/json-logs
branch
from
408dad3 to
57832dd
Compare
ItsGenis
force-pushed
the
feature/json-logs
branch
from
fbb4940 to
565cf58
Compare
|
@Dor3nz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @oriolgual and @mrcasals to be potential reviewers. |
|
Niiice. |
* Opening commit 🚧 * Don't display follows, scopes, and types on cards * Fix offenses * User super * Fix tests * Fix offenses
📌 Related Issues
Add lograge for json logs AjuntamentdeBarcelona/decidim-barcelona#78
👻 GIF