Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix exception in Initiatives' Page' to v0.26 #11024

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport #10928 to v0.26

♥️ Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: initiatives type: fix PRs that implement a fix for a bug labels Jun 14, 2023
@alecslupu alecslupu added this to the 0.26.8 milestone Jun 14, 2023
@alecslupu alecslupu force-pushed the backport/0.26/fix-exception-in-initiatives-p-10928 branch from 9aa04bf to 1ac6537 Compare June 14, 2023 13:37
* Add spec for checking that the Page inside of an Initiative works

* Fix bug during creation of Initiatives

* Fix bug on seeding Initiatives

* Add one time action on RELEASE_NOTES with the fix

* Fix rubocop offense

* Fix rubocop offense

* Fix path and filename of the rake task

* Fix typo

Suggested on code review

Co-authored-by: Alexandru Emil Lupu <[email protected]>

* Add PR id in RELEASE_NOTES

Suggested on code review

Co-authored-by: Alexandru Emil Lupu <[email protected]>

---------

Co-authored-by: Alexandru Emil Lupu <[email protected]>
@alecslupu alecslupu force-pushed the backport/0.26/fix-exception-in-initiatives-p-10928 branch from 1ac6537 to e9f8d73 Compare June 14, 2023 19:41
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a one time action made by the implementer:

### 3.7. Initiatives pages exception fix

It isn't here because we didn't have the RELEASE_NOTES.md file on this version, as it was introduced on #10031 (after cutting the releases). Can you add it to the CHANGELOG.md 🙏🏽 ?

@alecslupu alecslupu requested a review from andreslucena June 15, 2023 07:43
@andreslucena
Copy link
Member

Oh I've just noticed that as this bug was introduced with #8725 and that's only available in v0.27, we don't need to backport this to v0.26. I'll close this PR.

@alecslupu alecslupu deleted the backport/0.26/fix-exception-in-initiatives-p-10928 branch June 15, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: initiatives type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants