Fix dynamic upload file field required indicator + make option naming consistent #10497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix missing required file indicator from the dynamic upload file field label - Refactor the `optional` option for the file field and upload modal to `required` (inverse option) to maintain concistency over the option naming for all form fields
ahukkanen
added
module: proposals
module: core
module: admin
module: system
module: elections
module: assemblies
module: participatory processes
module: conferences
module: initiatives
type: fix
alecslupu
approved these changes
Mar 12, 2023
alecslupu
pushed a commit
that referenced
this pull request
Mar 13, 2023
… consistent (#10497) * Fix file field required indicator + consistency on option naming - Fix missing required file indicator from the dynamic upload file field label - Refactor the `optional` option for the file field and upload modal to `required` (inverse option) to maintain concistency over the option naming for all form fields * Fix a11y issue with the label `for` attribute in the upload label
alecslupu
pushed a commit
that referenced
this pull request
Mar 13, 2023
… consistent (#10497) * Fix file field required indicator + consistency on option naming - Fix missing required file indicator from the dynamic upload file field label - Refactor the `optional` option for the file field and upload modal to `required` (inverse option) to maintain concistency over the option naming for all form fields * Fix a11y issue with the label `for` attribute in the upload label
fblupi
pushed a commit
that referenced
this pull request
Mar 14, 2023
… consistent (#10497) (#10541) * Fix file field required indicator + consistency on option naming - Fix missing required file indicator from the dynamic upload file field label - Refactor the `optional` option for the file field and upload modal to `required` (inverse option) to maintain concistency over the option naming for all form fields * Fix a11y issue with the label `for` attribute in the upload label Co-authored-by: Antti Hukkanen <[email protected]>
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
…le-card * feature/redesign: (94 commits) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) Fix dynamic upload file field required indicator + make option naming consistent (#10497) Standardize the format of the words "should not" (#10515) Standardize the format of the words "were not" (#10516) ...
entantoencuanto
added a commit
that referenced
this pull request
Mar 23, 2023
* feature/redesign: (94 commits) Fix test Finalize word standardization (#10557) Fix iframes stripped from admin entered proposals, meetings and debates (#10466) Fix ImageMagick errors when trying to identify image dimensions (#10343) Add required to proposal limit field in Proposal component (#10525) Standardize the format of the words "is not" (#10511) Standardize the format of the words "has not" (#10510) Standardize the format of the words "will not" (#10509) Make buttons respect the organizations' primary color (#10526) Fix flaky spec for questionnaire templates (#10544) Remove the deprecated `optional` option from the file upload modal (#10542) Standardize the format of the words "does not" (#10505) Standardize the format of the words "was not" (#10514) Add Procfile support (#10519) Standardize the format of the words "do not" (#10513) Change the `optional` option to `required` at participatory texts (#10498) Fix destroying scope types that have been associated with processes (#10496) Fix dynamic upload file field required indicator + make option naming consistent (#10497) Standardize the format of the words "should not" (#10515) Standardize the format of the words "were not" (#10516) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix missing required file indicator from the dynamic upload file field label as described at #10495.
Additionally, refactor the
optionaloption for the file field and upload modal torequired(inverse option) to maintain consistency over the option naming for all form fields. Other fields, such astext_areahave therequiredoption and it is consistent with the HTML spec, see:https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/required
Note that for this PR I am still maintaining support for the
optionalattribute to make this change backportable. After this PR is merged, I will create another PR that removes that option for thedevelopbranch.📌 Related Issues
Testing
📷 Screenshots