Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 'Fix proposal etiquette and length validator with base64 images' to v0.26 #10010

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Backport 'Fix proposal etiquette and length validator with base64 images' to v0.26 #10010

merged 3 commits into from
Nov 3, 2022

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #9639 to v0.26

♥️ Thank you!

@ahukkanen @andreslucena
Fix proposal etiquette and length validator with base64 images (#9639)
e4f4721 
* Fix proposal etiquette and length validator with base64 images

* Use strip_tags instead of nokogiri not to include hidden content

Content e.g. in `<script>` tags should be automatically hidden,
so this should not be included in the validation either.

* Fix the expected base64 mime types
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug module: core module: proposals type: fix PRs that implement a fix for a bug labels Oct 28, 2022
ahukkanen
ahukkanen requested changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is broken because of a typo/different Ruby version.

decidim-proposals/spec/validators/proposal_length_validator_spec.rb Outdated Show resolved Hide resolved
ahukkanen
ahukkanen requested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be one more incompatibility with 0.26.

decidim-proposals/spec/validators/proposal_length_validator_spec.rb Outdated Show resolved Hide resolved
ahukkanen
ahukkanen approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The broken assemblies spec will be fixed by #10023.

@ahukkanen ahukkanen merged commit 13fbf28 into release/0.26-stable Nov 3, 2022
@ahukkanen ahukkanen deleted the backport/0.26/fix-proposal-etiquette-and-len-9639 branch November 3, 2022 16:33
@microstudi microstudi mentioned this pull request Feb 2, 2023
Closed
@alecslupu alecslupu added this to the 0.26.4 milestone Jul 14, 2023
@alecslupu alecslupu mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahukkanen ahukkanen ahukkanen approved these changes

Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug module: core module: proposals type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
0.26.4
Development

Successfully merging this pull request may close these issues.
3 participants
@andreslucena @ahukkanen @alecslupu