Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rails_12factor gem from the generator #1095

Closed
xredo opened this issue Mar 9, 2017 · 2 comments
Closed

Remove rails_12factor gem from the generator #1095

xredo opened this issue Mar 9, 2017 · 2 comments
Assignees

Comments

@xredo
Copy link
Contributor

xredo commented Mar 9, 2017

This is a Feature Proposal

🎩 Description

Currently the Decidim generator is including the rails_12factor gem. This is no longer needed for Rails 5.x applications as stated in the gem README: https://github.com/heroku/rails_12factor#new-rails-5-apps

New Rails 5 Apps
If you are starting a new application with Rails 5, you do not need this gem.

Also, removing this default is an improvement for organizations that want to install Decidim on premises instead of using a distributed cloud environment. 12factor apps should should be encouraged but I don't believe they should be enforced.

📌 Related issues

#1090

📋 Additional Data

@josepjaume
Copy link
Contributor

Oh, you're definitely right! Can you send a PR removing this from https://github.com/AjuntamentdeBarcelona/decidim/blob/master/lib/generators/decidim/templates/Gemfile.erb ?

@andreslucena
Copy link
Member

I went ahead and did it myself :)

@ghost ghost removed the in-progress label Mar 23, 2017
Quentinchampenois pushed a commit to Quentinchampenois/decidim that referenced this issue Feb 22, 2021
* Backport decidim#7028

* Normalize locales

* Add missing fr translation

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Update decidim-initiatives/config/locales/fr.yml

Co-authored-by: Pauline Bessoles <[email protected]>

* Fix malformed yaml

* Fix en offenses

Co-authored-by: Pauline Bessoles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants