Allow to limit non-accepted amendments in proposals #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 96.48% 96.50% +0.02%
==========================================
Files 123 124 +1
Lines 3467 3492 +25
==========================================
+ Hits 3345 3370 +25
Misses 122 122 ☔ View full report in Codecov by Sentry. |
4 tasks
* New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Japanese) * New translations en.yml (German) * New translations en.yml (Romanian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Japanese) * New translations en.yml (Czech)
microstudi
added a commit
that referenced
this pull request
May 8, 2024
* add admin config option in proposals * add amendments controller concern * limit amendments on controller * limit only new and create methods * add modal explanation window * do not show modal if amendments limit disabled * add test cases * fx locales * add readme * fix locales * remove quotes * remove space * New Crowdin updates (#264) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Japanese) * New translations en.yml (German) * New translations en.yml (Romanian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Japanese) * New translations en.yml (Czech) * New translations en.yml (Japanese) (#269) * skip hidden emendations --------- Co-authored-by: PokeCode Bot <[email protected]>
Merged
microstudi
added a commit
that referenced
this pull request
May 17, 2024
* Allow to limit non-accepted amendments in proposals (#261) * add admin config option in proposals * add amendments controller concern * limit amendments on controller * limit only new and create methods * add modal explanation window * do not show modal if amendments limit disabled * add test cases * fx locales * add readme * fix locales * remove quotes * remove space * New Crowdin updates (#264) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Japanese) * New translations en.yml (German) * New translations en.yml (Romanian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Japanese) * New translations en.yml (Czech) * New translations en.yml (Japanese) (#269) * skip hidden emendations --------- Co-authored-by: PokeCode Bot <[email protected]> * remove file * fix ca file * change modal * fix rubocop * fic npm lint * undo the changes * fix modal, fix test * fix limit modal override * remove spaces * simplify implementation * fix flaky scoped admins * fix intergram spec * fix specs * amendment image * fix linking the correct amendmentd --------- Co-authored-by: PokeCode Bot <[email protected]> Co-authored-by: Anna Topalidi <[email protected]>
microstudi
added a commit
that referenced
this pull request
Jul 28, 2024
* admin form_builder private fields * chore: CustomFieldsBuilders is a [public, private] array * fixup! chore: CustomFieldsBuilders is a [public, private] array * refacto: CustomFieldsBuilders is a hash of editor * chore: handle renaming key with private fields * logs: remove debugging * chore: show private fields form * chore: show private fields on create form * chore: display private field editors in proposals * chore: save private body in DB and display it admin side * fix: migration on decidim 0.24 * fix: more robust way to know if a proposal is new * fix: edit proposal private fields * wip: move 024 fixes to 026 * chore: improve UX on editor * fix: export custom fields * compat: simple_proposal fields * fix: private fields isolation * New Crowdin updates (#294) * New translations en.yml (Czech) * New translations en.yml (Czech) * Allow to limit non-accepted amendments in proposals (#261) * add admin config option in proposals * add amendments controller concern * limit amendments on controller * limit only new and create methods * add modal explanation window * do not show modal if amendments limit disabled * add test cases * fx locales * add readme * fix locales * remove quotes * remove space * New Crowdin updates (#264) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Japanese) * New translations en.yml (German) * New translations en.yml (Romanian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Japanese) * New translations en.yml (Czech) * New translations en.yml (Japanese) (#269) * skip hidden emendations --------- Co-authored-by: PokeCode Bot <[email protected]> * fix hidden images in public proposals (#301) * fix hidden images in public proposals * fix offences * fix 27 configuration * fix overrides * fix: default to english on custom proposal fields * lint: automatic rubocop corrections * lint: fix offenses * fix: don't update custom_fields_renderer * fix: en locales * refactor: rename export name for explicit trad * New Crowdin updates (#303) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Italian) * New translations en.yml (Japanese) * chore: move private_fields to decidim_awesome_proposal_extra_fields * fix: rubocop ofenses * clean PR * chore: handle empty fieldsets * chore: improve admin readability * chore: remove cards where it makes no sense to have card * chore: encrypt private data * revert: leave package-lock untouch * fixup! revert: leave package-lock untouch * fix: rubocop * chore: prettier on eslint on packs * fix: tests * fix: rubocop * add proposal_custom_fields submenu * add proposal_private_custom_fields view * delete unused migration * fix rubocop * add disclosure for proposal_private_custom_fields * apply styles to proposal_private_custom_fields * refactor views * use standard attribute encryptors * add custom fields specs * remove wrong deface * fix styles on form * clean form * add commands specs * fix rendering * fix javascript * ffi * summary fixes * fix more specs * convert to polymorphic * fix specs, fix amendments * fix specs * fix serialzier specs * fix export specs * version bump * readme image * add private display in admin * fix checksums * add notes export * handle translations * add docs * changelog --------- Co-authored-by: Renato <[email protected]> Co-authored-by: Hadrien Froger <[email protected]> Co-authored-by: PokeCode Bot <[email protected]> Co-authored-by: Ivan Vergés <[email protected]> Co-authored-by: elviabth <[email protected]>
antopalidi
pushed a commit
that referenced
this pull request
Aug 8, 2024
* admin form_builder private fields * chore: CustomFieldsBuilders is a [public, private] array * fixup! chore: CustomFieldsBuilders is a [public, private] array * refacto: CustomFieldsBuilders is a hash of editor * chore: handle renaming key with private fields * logs: remove debugging * chore: show private fields form * chore: show private fields on create form * chore: display private field editors in proposals * chore: save private body in DB and display it admin side * fix: migration on decidim 0.24 * fix: more robust way to know if a proposal is new * fix: edit proposal private fields * wip: move 024 fixes to 026 * chore: improve UX on editor * fix: export custom fields * compat: simple_proposal fields * fix: private fields isolation * New Crowdin updates (#294) * New translations en.yml (Czech) * New translations en.yml (Czech) * Allow to limit non-accepted amendments in proposals (#261) * add admin config option in proposals * add amendments controller concern * limit amendments on controller * limit only new and create methods * add modal explanation window * do not show modal if amendments limit disabled * add test cases * fx locales * add readme * fix locales * remove quotes * remove space * New Crowdin updates (#264) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Japanese) * New translations en.yml (German) * New translations en.yml (Romanian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Japanese) * New translations en.yml (Czech) * New translations en.yml (Japanese) (#269) * skip hidden emendations --------- Co-authored-by: PokeCode Bot <[email protected]> * fix hidden images in public proposals (#301) * fix hidden images in public proposals * fix offences * fix 27 configuration * fix overrides * fix: default to english on custom proposal fields * lint: automatic rubocop corrections * lint: fix offenses * fix: don't update custom_fields_renderer * fix: en locales * refactor: rename export name for explicit trad * New Crowdin updates (#303) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Italian) * New translations en.yml (Japanese) * chore: move private_fields to decidim_awesome_proposal_extra_fields * fix: rubocop ofenses * clean PR * chore: handle empty fieldsets * chore: improve admin readability * chore: remove cards where it makes no sense to have card * chore: encrypt private data * revert: leave package-lock untouch * fixup! revert: leave package-lock untouch * fix: rubocop * chore: prettier on eslint on packs * fix: tests * fix: rubocop * add proposal_custom_fields submenu * add proposal_private_custom_fields view * delete unused migration * fix rubocop * add disclosure for proposal_private_custom_fields * apply styles to proposal_private_custom_fields * refactor views * use standard attribute encryptors * add custom fields specs * remove wrong deface * fix styles on form * clean form * add commands specs * fix rendering * fix javascript * ffi * summary fixes * fix more specs * convert to polymorphic * fix specs, fix amendments * fix specs * fix serialzier specs * fix export specs * version bump * readme image * add private display in admin * fix checksums * add notes export * handle translations * add docs * changelog --------- Co-authored-by: Renato <[email protected]> Co-authored-by: Hadrien Froger <[email protected]> Co-authored-by: PokeCode Bot <[email protected]> Co-authored-by: Ivan Vergés <[email protected]> Co-authored-by: elviabth <[email protected]>
microstudi
added a commit
that referenced
this pull request
Aug 19, 2024
* Add private fields to proposal components (#314) * admin form_builder private fields * chore: CustomFieldsBuilders is a [public, private] array * fixup! chore: CustomFieldsBuilders is a [public, private] array * refacto: CustomFieldsBuilders is a hash of editor * chore: handle renaming key with private fields * logs: remove debugging * chore: show private fields form * chore: show private fields on create form * chore: display private field editors in proposals * chore: save private body in DB and display it admin side * fix: migration on decidim 0.24 * fix: more robust way to know if a proposal is new * fix: edit proposal private fields * wip: move 024 fixes to 026 * chore: improve UX on editor * fix: export custom fields * compat: simple_proposal fields * fix: private fields isolation * New Crowdin updates (#294) * New translations en.yml (Czech) * New translations en.yml (Czech) * Allow to limit non-accepted amendments in proposals (#261) * add admin config option in proposals * add amendments controller concern * limit amendments on controller * limit only new and create methods * add modal explanation window * do not show modal if amendments limit disabled * add test cases * fx locales * add readme * fix locales * remove quotes * remove space * New Crowdin updates (#264) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Japanese) * New translations en.yml (German) * New translations en.yml (Romanian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (German) * New translations en.yml (French) * New translations en.yml (Japanese) * New translations en.yml (Czech) * New translations en.yml (Japanese) (#269) * skip hidden emendations --------- Co-authored-by: PokeCode Bot <[email protected]> * fix hidden images in public proposals (#301) * fix hidden images in public proposals * fix offences * fix 27 configuration * fix overrides * fix: default to english on custom proposal fields * lint: automatic rubocop corrections * lint: fix offenses * fix: don't update custom_fields_renderer * fix: en locales * refactor: rename export name for explicit trad * New Crowdin updates (#303) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (German) * New translations en.yml (Italian) * New translations en.yml (Japanese) * chore: move private_fields to decidim_awesome_proposal_extra_fields * fix: rubocop ofenses * clean PR * chore: handle empty fieldsets * chore: improve admin readability * chore: remove cards where it makes no sense to have card * chore: encrypt private data * revert: leave package-lock untouch * fixup! revert: leave package-lock untouch * fix: rubocop * chore: prettier on eslint on packs * fix: tests * fix: rubocop * add proposal_custom_fields submenu * add proposal_private_custom_fields view * delete unused migration * fix rubocop * add disclosure for proposal_private_custom_fields * apply styles to proposal_private_custom_fields * refactor views * use standard attribute encryptors * add custom fields specs * remove wrong deface * fix styles on form * clean form * add commands specs * fix rendering * fix javascript * ffi * summary fixes * fix more specs * convert to polymorphic * fix specs, fix amendments * fix specs * fix serialzier specs * fix export specs * version bump * readme image * add private display in admin * fix checksums * add notes export * handle translations * add docs * changelog --------- Co-authored-by: Renato <[email protected]> Co-authored-by: Hadrien Froger <[email protected]> Co-authored-by: PokeCode Bot <[email protected]> Co-authored-by: Ivan Vergés <[email protected]> Co-authored-by: elviabth <[email protected]> * fix engine syntax * Add clear old private data controller (#316) * add maintenance controller * standarize views * fix gemfile * fix gemfile * fix gemfile * add presenters * add action log * add specs * add specs * add private data info * add specs * add last specs * fix spec * fix syntax * fix erb * fix tests for: commands, controllers * fix tests, menu, images in editor * fix spec/lib * fix spec.permissions * fix presenter * fix modals * add x86_64-linux to platforms, change icons * Gemfile.lock * Gemfile.lock * change app version in Gemfile.legacy.lock * fix rubocop * fix stylelint * erblint * change icons * fix text_editor * refactoring render_proposal_custom_fields_override * fix menu, icons * remove breadcrumb * remove ContentSecurityPolicy * fix menu hacks * fix edit proposal spec * fix custom fields form * fix specs * fix AmendmentsHelperOverride * fix spec javascript config vars * fix spec * fix npm lint * fix awesome_summary_spec * fix controllers specs * fix menu, classes, titles * controller spec * fix tests, add class to label editor * fix js, specs * fix tests * fix test * fix overrides and old javascript * fix auto_edit.js * fix override for drafts * fix voting spec * fix styles * change public styles * change public styles * remove apply * fix script * lint & 26 * fix version * fix autoedit * downgrade activrecord syntax * readd css rule --------- Co-authored-by: hfroger <[email protected]> Co-authored-by: Renato <[email protected]> Co-authored-by: Hadrien Froger <[email protected]> Co-authored-by: PokeCode Bot <[email protected]> Co-authored-by: Ivan Vergés <[email protected]> Co-authored-by: elviabth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixes Green-Party-of-Canada-Members/gpc-decidim#126