-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 0.28 - Initial adaptation #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entantoencuanto
changed the title
Redesign
Upgrade to 0.28 - Initial adaptation, 6. Awesome map component, 7. Fullscreen Iframe component
Nov 20, 2023
The section container of the iframe does not have margins so this setting is useless applying redesign
This was referenced Feb 8, 2024
Merged
13 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #251
This PR is a step in the adaptation of DecidimAwesome to Decidim 0.28 version, which has important changes on the front. At the moment this PR focuses on the parts of the gem that require less of the front-end changes introduced by the module, such as the Fullscreen Iframe and Awesome map components or the menu tweaks or admin assignations to specific scopes
This PR:
Makes the essential changes in the gem to make it work in the development environment with a version of Decidim that uses the develop branch (preparing 0.28 release):
Adapts blank_component controller to work with 0.28 release adding a method for breadcrumbs
Adapts Fullscreen Iframe component to 0.28
Adapts Awesome Maps component to 0.28
Pending:
NOTE - This is a currently work in progress, take in account that this module adapts some parts to 0.28 and disables some other so currently there will be a lot of broken features