Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.28 - Initial adaptation #253

Merged
merged 127 commits into from
Feb 8, 2024
Merged

Upgrade to 0.28 - Initial adaptation #253

merged 127 commits into from
Feb 8, 2024

Conversation

entantoencuanto
Copy link
Contributor

@entantoencuanto entantoencuanto commented Nov 17, 2023

Related to #251

This PR is a step in the adaptation of DecidimAwesome to Decidim 0.28 version, which has important changes on the front. At the moment this PR focuses on the parts of the gem that require less of the front-end changes introduced by the module, such as the Fullscreen Iframe and Awesome map components or the menu tweaks or admin assignations to specific scopes

This PR:

  • Makes the essential changes in the gem to make it work in the development environment with a version of Decidim that uses the develop branch (preparing 0.28 release):

    • Changing dependencies in the Gemfile
    • Moving the changes from ProposalMCellOverride (m-cells are deprecated in 0.28) to proposals l-cells. These modifications are pending redesign.
    • Temporarily disables the module's custom js and css
  • Adapts blank_component controller to work with 0.28 release adding a method for breadcrumbs

  • Adapts Fullscreen Iframe component to 0.28
    Screenshot from 2023-11-20 11-18-50

  • Adapts Awesome Maps component to 0.28

Screenshot from 2023-11-20 16-02-11

  • Adapts the Menu Hacks feature to 0.28 and overrides breadcrumb menu item presenter to allow the use of links opened in a new window. It also allows to edit the content block main menu which may appear in the homepage

Screenshot from 2023-12-05 18-00-07
Screenshot from 2023-12-05 18-03-08

  • Adapts the modals used to create and edit constraints to decidim_modals introduced in 0.28
  • Recovers the custom css code applied by scopes defined by admins in awesome menu
  • Adapts the scopes custom css admin management

image

  • Adapts the scopes admins tweaks admin management

image (1)

  • Updates the icons used by the module to use existing declared ones or register new icons specific of the module
  • Refactors the secondary nav menu of the module to use the same conventions of Decidim 0.28
  • Changes the tests of the adapted features both in admin and front
  • Adds skips to a lot of tests related with functionalities not adapted yet to 0.28
  • Copies current configuration of rubocop in Decidim 0.28 and fixes the existing offenses
  • Renames the 0.27 workflows to 0.28 and removes the 0.26 workflow

Pending:

  • See Upgrade to 0.28 - Admin front updates #257
  • Linters: There is currently a problem trying to get js and styles linters configuration because the release 0.28 does not exist and using references to 0.27 seems to break the compilation of the application in the CI engine
  • Tests: Remove references in tests to deprecated legacy versions

image (4)

NOTE - This is a currently work in progress, take in account that this module adapts some parts to 0.28 and disables some other so currently there will be a lot of broken features

@entantoencuanto entantoencuanto changed the title Redesign Upgrade to 0.28 - Initial adaptation, 6. Awesome map component, 7. Fullscreen Iframe component Nov 20, 2023
@microstudi microstudi changed the base branch from main to develop November 20, 2023 11:46
@microstudi microstudi mentioned this pull request Nov 20, 2023
20 tasks
@microstudi microstudi merged commit 7b356fe into develop Feb 8, 2024
7 of 8 checks passed
@microstudi microstudi deleted the redesign branch February 8, 2024 13:16
This was referenced Feb 8, 2024
@microstudi microstudi mentioned this pull request Mar 11, 2024
13 tasks
@microstudi microstudi mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants