Merge pull request #270 from decidim-ice/develop

Upgrade to 0.28

.github/workflows/lint.yml

@@ -7,8 +7,8 @@ on:
   pull_request:
 
 env:
-  RUBY_VERSION: 3.0.6
-  NODE_VERSION: 16.9.1
+  RUBY_VERSION: 3.1.1
+  NODE_VERSION: 18.17.1
 
 jobs:
   lint-report:

.github/workflows/tests.yml

@@ -1,4 +1,4 @@
-name: "[CI] Tests 0.27"
+name: "[CI] Tests 0.28"
 
 on:
   push:
@@ -9,27 +9,24 @@ on:
 env:
   CI: 1
   SIMPLECOV: 1
-  NODE_VERSION: 16.9.1
-  RUBY_VERSION: 3.0.6
+  NODE_VERSION: 18.17.1
+  RUBY_VERSION: 3.1.1
   BUNDLE_GEMFILE: Gemfile
+  DISPLAY: ":99"
+  PARALLEL_TEST_PROCESSORS: 2
+  SHAKAPACKER_RUNTIME_COMPILE: "false"
+  NODE_ENV: "test"
+  RAILS_ENV: "test"
+  RUBYOPT: '-W:no-deprecated'
+  DATABASE_USERNAME: postgres
+  DATABASE_PASSWORD: postgres
+  DATABASE_HOST: localhost
+  POSTGRES_PASSWORD: postgres
 
 jobs:
-  tests-latest:
+  build:
+    name: Build & Precompile
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        include:
-          - rspec: awesome_summary_spec.rb
-            features: disabled
-          - rspec: " --exclude-pattern 'spec/system/**/*_spec.rb'"
-            features: enabled
-          - rspec: system/admin
-            features: enabled
-          - rspec: system/*_spec.rb
-            features: enabled
-          - rspec: system/awesome_map
-            features: enabled
-      fail-fast: false
 
     services:
       postgres:
@@ -42,10 +39,6 @@ jobs:
           --health-retries 5
         env:
           POSTGRES_PASSWORD: postgres
-    env:
-      DATABASE_USERNAME: postgres
-      DATABASE_PASSWORD: postgres
-      DATABASE_HOST: localhost
 
     steps:
       - uses: actions/checkout@v4
@@ -75,18 +68,104 @@ jobs:
         with:
           node-version: ${{ env.NODE_VERSION }}
 
-      - name: Setup Test App
-        run: bundle exec rake test_app
+      - uses: actions/cache@v3
+        id: app-cache
+        with:
+          path: ./spec/decidim_dummy_app/
+          key: app-${{ github.sha }}
+          restore-keys: app-${{ github.sha }}
+
+      - run: bundle exec rake test_app
+        name: Create test app
+        shell: "bash"
+
+      - run: mkdir -p ./spec/decidim_dummy_app/tmp/screenshots
+        name: Create the screenshots folder
+        shell: "bash"
+
+      - run: bundle exec rails assets:precompile
+        name: Precompile assets
+        working-directory: ./spec/decidim_dummy_app/
+        shell: "bash"
+        env:
+          BUNDLE_GEMFILE: ../../Gemfile
+
+      - run: tar -zcf /tmp/testapp-env.tar.gz ./spec/decidim_dummy_app
+
+      - uses: actions/upload-artifact@v3
+        with:
+          name: workspace
+          path: /tmp/testapp-env.tar.gz
+
+  tests-latest:
+    name: Tests latest
+    runs-on: ubuntu-latest
+    needs: build
+
+    strategy:
+      matrix:
+        include:
+          - rspec: spec/awesome_summary_spec.rb
+            features: disabled
+          - rspec: spec\/(?!system)
+            features: enabled
+          - rspec: spec/system/admin
+            features: enabled
+          - rspec: spec/system/public
+            features: enabled
+          - rspec: spec/system/awesome_map
+            features: enabled
+      fail-fast: false
+
+    services:
+      postgres:
+        image: postgres:11
+        ports: ["5432:5432"]
+        options: >-
+          --health-cmd pg_isready
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        env:
+          POSTGRES_PASSWORD: postgres
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ env.RUBY_VERSION }}
+          bundler-cache: true
+
+      - uses: actions/download-artifact@v3
+        with:
+          name: workspace
+          path: /tmp
+
+      - run: tar -zxf /tmp/testapp-env.tar.gz
+        name: Restore application
+
+      - run: bundle exec rake parallel:create parallel:load_schema
+        name: Parallel tests
+        shell: "bash"
+        working-directory: ./spec/decidim_dummy_app/
+        env:
+          BUNDLE_GEMFILE: ../../Gemfile
 
       - name: General RSpec with config vars ${{ matrix.features }}
-        run: bundle exec rspec spec/${{ matrix.rspec }}
+        run: |
+          sudo Xvfb -ac $DISPLAY -screen 0 1920x1084x24 > /dev/null 2>&1 & # optional
+          ln -s spec/decidim_dummy_app spec/decidim_dummy_app_last
+          bundle exec rake parallel:spec['${{ matrix.rspec }}']
         env:
           FEATURES: ${{ matrix.features }}
 
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v3
 
-      - uses: actions/upload-artifact@v2-preview
+      - uses: actions/upload-artifact@v3
         if: always()
         with:
           name: screenshots

.gitignore

@@ -24,3 +24,4 @@ node_modules/
 npm_debug.log
 
 .ruby-version
+.rubocop-http*

.gitpod.dockerfile

@@ -5,4 +5,4 @@ RUN sudo apt-get update  && sudo apt-get install -y redis-server apt-transport-h
 USER gitpod
 SHELL ["/bin/bash", "-c"]
 
-RUN cd && /home/gitpod/.rvm/bin/rvm install "ruby-3.0.5"
+RUN cd && /home/gitpod/.rvm/bin/rvm install "ruby-3.1.1"

.gitpod.yml

@@ -8,7 +8,7 @@ tasks:
     command: bundle exec rspec
   #- name: webpacker
   #  before: rvm --default use "ruby-3.0.4"
-  #  command: bin/webpack-dev-server
+  #  command: bin/shakapacker-dev-server
 vscode:
   extensions:
     - dbaeumer.vscode-eslint