Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegSvr error with version 0.3 #15

Closed
josephernest opened this issue Oct 25, 2018 · 5 comments
Closed

RegSvr error with version 0.3 #15

josephernest opened this issue Oct 25, 2018 · 5 comments
Assignees
@dechamps
Labels
bug

Comments

@josephernest
Copy link

josephernest commented Oct 25, 2018 •
edited
Loading

When installing FlexASIO-0.3.exe with Windows 7 x64, I get this message:

Imgur

NB: the previous version 0.2 has been successfully uninstalled before trying to install the new one.

I also tried manually but it seems to be the same error:

Imgur
@dechamps
Copy link
Owner

Sorry to hear that. This surprises me, as I never saw that kind of error during my own testing. Can you try running FlexASIOTest_x64.exe? Does it run correctly?

I'm using Windows 10, maybe that has something to do with it. I soon as I get some time I'll try to reproduce this in a Windows 7 x64 virtual machine.

In the mean time, one way to gather more details on your side would be to look at the Windows Event Viewer, which can sometimes include information about that kind of error. It might also be worth trying Process Monitor to examine what the regsvr32 process is trying to do while it's failing.

@josephernest
Copy link
Author

With FlexASIOTest_x64.exe, I get this error:

image

@dechamps
Copy link
Owner

Thank you, that tells me all I need to know. The problem is that FlexASIO 0.3 is using the GetSystemTimePreciseAsFileTime() function to get timestamps for logging (see 851a68e), but the thing I missed is that this function is only available from Windows 8 onwards, hence the failure. My bad. I was naively assuming that the Windows SDK version targeting system would prevent me from using features that are not available in old versions of Windows, but it looks like I was wrong. I'll try to come up with a fix within the next 24 hours.

@dechamps dechamps added the bug label Oct 26, 2018
@dechamps dechamps self-assigned this Oct 26, 2018
@dechamps
Copy link
Owner

This is fixed in FlexASIO 0.3a. Thanks for the feedback!

dechamps added a commit that referenced this issue Oct 27, 2018
@dechamps
Target the Windows 7 API set.
2a81e7a 
This should prevent accidental use of APIs that are only available
on Windows 8 and later.

Sadly, it looks like GetSystemTimePreciseAsFileTime() doesn't honour
these macros, so this would not have prevented #15; see
https://wpdev.uservoice.com/forums/110705/suggestions/35836531.
However, perhaps it can prevent this kind of issue for other APIs.
@josephernest
Copy link
Author

josephernest commented Oct 28, 2018 •
edited
Loading

@dechamps Solved on Windows 7. Installation successful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dechamps dechamps

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dechamps @josephernest