Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new test vector #119

Merged
merged 2 commits into from
Mar 5, 2024
Merged

add new test vector #119

merged 2 commits into from
Mar 5, 2024

Conversation

nitro-neal
Copy link
Contributor

No description provided.

@nitro-neal nitro-neal marked this pull request as ready for review February 29, 2024 19:03
decentralgabe
decentralgabe approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙

@jiyoonie9
Copy link
Contributor

is there a corresponding web5-kt PR that points to this test vector branch and the CI passes?

jiyoonie9
jiyoonie9 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@jiyoonie9 jiyoonie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo 🎉

approved, but let's make sure we have web5-kt (and web5-js) PRs that pulls in this change and has the tests pass!

@nitro-neal nitro-neal merged commit 7c61753 into main Mar 5, 2024
1 check passed
@nitro-neal nitro-neal deleted the jwt-verify-test-vectors branch March 5, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyoonie9 jiyoonie9 jiyoonie9 approved these changes

@decentralgabe decentralgabe decentralgabe approved these changes

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

@frankhinek frankhinek Awaiting requested review from frankhinek

@amika-sq amika-sq Awaiting requested review from amika-sq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitro-neal @jiyoonie9 @decentralgabe