Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dht example #116

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Fix dht example #116

merged 5 commits into from
Mar 21, 2024

Conversation

nitro-neal
Copy link
Contributor

@nitro-neal nitro-neal commented Feb 13, 2024

Fix dht example to have a valid did dht and create a new test for an invalid did dht

web5-kt update spec - decentralized-identity/web5-kt#237
web5-js add test vectors - decentralized-identity/web5-js#453

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@frankhinek
Copy link
Contributor

@nitro-neal The invalidPublicKey error is only implemented in Web5 JS, correct? In other words, we'd have to update KT, Swift, etc. for them to pass this vector?

@nitro-neal
Copy link
Contributor Author

They pass in kt and its not yet implemented in swift 👍

@nitro-neal nitro-neal requested a review from finn-block as a code owner March 21, 2024 21:39
@nitro-neal nitro-neal merged commit 77f2cbd into main Mar 21, 2024
@nitro-neal nitro-neal deleted the fix-dht-example branch March 21, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants