Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK Feature Report Generator to be more flexible in handling test naming #100

Closed
frankhinek opened this issue Jan 11, 2024 · 0 comments · Fixed by #101
Closed

Update SDK Feature Report Generator to be more flexible in handling test naming #100

frankhinek opened this issue Jan 11, 2024 · 0 comments · Fixed by #101
Assignees
@finn-block
Labels
bug Something isn't working testing related to new or existing tests

Comments

@frankhinek
Copy link
Contributor

frankhinek commented Jan 11, 2024 •
edited
Loading

During this workflow run an issue with discovered with how test names with spaces can cause the pattern matching in SDK Feature Report Generator to miss a test vector result.

Instead of:

2024/01/11 12:40:57 INFO regex success for test sdk=web5-js before="Verifiable Credential Tests Web5TestVectorsCredentials verify" after=Tests

It should have been:

2024/01/11 12:40:57 INFO regex success for test sdk=web5-js before="Verifiable Credential Tests Web5TestVectorsCredentials verify" after=verify

Rather than requiring every developer writing tests to have to be aware that they can't use spaces or impose other constraints, the preference is to improve how the report generator matches.

More context in this Discord thread
@frankhinek frankhinek added bug Something isn't working testing related to new or existing tests test-harness labels Jan 11, 2024
@finn-block finn-block self-assigned this Jan 11, 2024
finn-block added a commit that referenced this issue Jan 11, 2024
@finn-block
web5-js didn't follow the old format, update regex
9bda3bd 
fixes #100
@finn-block finn-block mentioned this issue Jan 11, 2024
Merged
finn-block added a commit that referenced this issue Jan 11, 2024
@finn-block
update web5-js test name regex (#101)
a4f9fe0 
* web5-js didn't follow the old format, update regex

fixes #100

* fix README.md which was failing the lint job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@finn-block finn-block

Labels
bug Something isn't working testing related to new or existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update web5-js test name regex decentralized-identity/web5-spec
2 participants
@frankhinek @finn-block