generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
f321850
commit 136e106
Showing
6 changed files
with
122 additions
and
103 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
config: | ||
line-length: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
# Contribution Guide | ||
# Contribution Guide | ||
|
||
There are many ways to be an open source contributor, and we're here to help you on your way! You may: | ||
|
||
* Propose ideas in our | ||
* Propose ideas in our | ||
[discord](https://discord.gg/tbd) | ||
* Raise an issue or feature request in our [issue tracker](https://github.com/TBD54566975/web5-spec/issues) | ||
* Help another contributor with one of their questions, or a code review | ||
|
@@ -13,7 +13,7 @@ This guide is for you. | |
|
||
## Development Prerequisites | ||
|
||
___***UPDATE TABLE OF PROJECT DEPS AND INSTALLATION NOTES***___ | ||
___*__UPDATE TABLE OF PROJECT DEPS AND INSTALLATION NOTES__*___ | ||
|
||
| Requirement | Tested Version | Installation Instructions | | ||
|-------------|----------------|------------------------------------------------------| | ||
|
@@ -23,11 +23,11 @@ ___***UPDATE TABLE OF PROJECT DEPS AND INSTALLATION NOTES***___ | |
|
||
### Go | ||
|
||
This project is written in Go, a modern, open source programming language. | ||
This project is written in Go, a modern, open source programming language. | ||
|
||
You may verify your `go` installation via the terminal: | ||
|
||
``` | ||
```sh | ||
$> go version | ||
go version go1.17.6 darwin/amd64 | ||
``` | ||
|
@@ -37,7 +37,8 @@ If you do not have go, we recommend installing it by: | |
#### MacOS | ||
|
||
##### Homebrew | ||
``` | ||
|
||
```sh | ||
$> brew install go | ||
``` | ||
|
||
|
@@ -51,7 +52,7 @@ The build is run by Mage. | |
|
||
You may verify your `mage` installation via the terminal: | ||
|
||
``` | ||
```sh | ||
$> mage --version | ||
Mage Build Tool 1.12.1 | ||
Build Date: 2021-12-15T21:00:02Z | ||
|
@@ -73,21 +74,21 @@ Installation instructions are on the [Magefile home page](https://magefile.org/) | |
|
||
### Java | ||
|
||
This project is written in Java, a typesafe, compiled programming language. | ||
This project is written in Java, a typesafe, compiled programming language. | ||
|
||
You may verify your `java` installation via the terminal by running `java -version`. | ||
|
||
If you do not have Java, we recommend installing it | ||
via [SDKMan](https://sdkman.io/install). This is a project which will allow you | ||
to easily install the Java Development Kit (JDK), runtime (JRE), and related frameworks, | ||
If you do not have Java, we recommend installing it | ||
via [SDKMan](https://sdkman.io/install). This is a project which will allow you | ||
to easily install the Java Development Kit (JDK), runtime (JRE), and related frameworks, | ||
build tools, and runtimes. | ||
|
||
After you've installed SDKMan, you may install Java: | ||
|
||
#### SDKMan (cross-platform instructions) | ||
|
||
```shell | ||
$> sdk install java | ||
$> sdk install java | ||
... | ||
Do you want java 17.0.2-open to be set as default? (Y/n): Y | ||
Setting java 17.0.2-open as default. | ||
|
@@ -122,11 +123,13 @@ $> mage build | |
## Build (Java / Gradle) | ||
|
||
### macOS / Linux | ||
|
||
```shell | ||
$> ./gradlew build | ||
``` | ||
|
||
### Windows | ||
|
||
```shell | ||
$> gradlew.bat build | ||
``` | ||
|
@@ -140,11 +143,13 @@ $> mage test | |
## Test (Java / Gradle) | ||
|
||
### macOS / Linux | ||
Check failure on line 145 in CONTRIBUTING.md GitHub Actions / lintMultiple headings with the same content
|
||
|
||
```shell | ||
$> ./gradlew test | ||
``` | ||
|
||
### Windows | ||
Check failure on line 151 in CONTRIBUTING.md GitHub Actions / lintMultiple headings with the same content
|
||
|
||
```shell | ||
$> gradlew.bat test | ||
``` | ||
|
@@ -164,7 +169,7 @@ $> ./gradlew clean build test | |
|
||
### Issues | ||
|
||
Anyone from the community is welcome (and encouraged!) to raise issues via | ||
Anyone from the community is welcome (and encouraged!) to raise issues via | ||
[GitHub Issues](https://github.com/TBD54566975/web5-spec/issues). | ||
|
||
### Discussions | ||
|
@@ -179,34 +184,34 @@ Build and Test cycles are run on every commit to every branch on [GitHub Actions | |
|
||
## Contribution | ||
|
||
We review contributions to the codebase via GitHub's Pull Request mechanism. We have | ||
the following guidelines to ease your experience and help our leads respond quickly | ||
We review contributions to the codebase via GitHub's Pull Request mechanism. We have | ||
the following guidelines to ease your experience and help our leads respond quickly | ||
to your valuable work: | ||
|
||
* Start by proposing a change either in Issues (most appropriate for small | ||
change requests or bug fixes) or in Discussions (most appropriate for design | ||
and architecture considerations, proposing a new feature, or where you'd | ||
* Start by proposing a change either in Issues (most appropriate for small | ||
change requests or bug fixes) or in Discussions (most appropriate for design | ||
and architecture considerations, proposing a new feature, or where you'd | ||
like insight and feedback) | ||
* Cultivate consensus around your ideas; the project leads will help you | ||
pre-flight how beneficial the proposal might be to the project. Developing early | ||
buy-in will help others understand what you're looking to do, and give you a | ||
greater chance of your contributions making it into the codebase! No one wants to | ||
* Cultivate consensus around your ideas; the project leads will help you | ||
pre-flight how beneficial the proposal might be to the project. Developing early | ||
buy-in will help others understand what you're looking to do, and give you a | ||
greater chance of your contributions making it into the codebase! No one wants to | ||
see work done in an area that's unlikely to be incorporated into the codebase. | ||
* Fork the repo into your own namespace/remote | ||
* Work in a dedicated feature branch. Atlassian wrote a great | ||
* Work in a dedicated feature branch. Atlassian wrote a great | ||
[description of this workflow](https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow) | ||
* When you're ready to offer your work to the project, first: | ||
* Squash your commits into a single one (or an appropriate small number of commits), and | ||
rebase atop the upstream `main` branch. This will limit the potential for merge | ||
conflicts during review, and helps keep the audit trail clean. A good writeup for | ||
how this is done is | ||
[here](https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec), and if you're | ||
having trouble - feel free to ask a member or the community for help or leave the commits as-is, and flag that you'd like | ||
* Squash your commits into a single one (or an appropriate small number of commits), and | ||
rebase atop the upstream `main` branch. This will limit the potential for merge | ||
conflicts during review, and helps keep the audit trail clean. A good writeup for | ||
how this is done is | ||
[here](https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec), and if you're | ||
having trouble - feel free to ask a member or the community for help or leave the commits as-is, and flag that you'd like | ||
rebasing assistance in your PR! We're here to support you. | ||
* Open a PR in the project to bring in the code from your feature branch. | ||
* The maintainers noted in the `CODEOWNERS` file will review your PR and optionally | ||
* The maintainers noted in the `CODEOWNERS` file will review your PR and optionally | ||
open a discussion about its contents before moving forward. | ||
* Remain responsive to follow-up questions, be open to making requested changes, and... | ||
You're a contributor! | ||
* And remember to respect everyone in our global development community. Guidelines | ||
* And remember to respect everyone in our global development community. Guidelines | ||
are established in our `CODE_OF_CONDUCT.md`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.