-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secp256k1 signer & verifier, fix serde deserialize optional timestamp bug, add vc verify test vector #350
Conversation
@@ -22,13 +22,15 @@ pub struct JwtPayloadVerifiableCredential { | |||
#[serde( | |||
rename = "issuanceDate", | |||
serialize_with = "serialize_optional_system_time", | |||
deserialize_with = "deserialize_optional_system_time" | |||
deserialize_with = "deserialize_optional_system_time", | |||
default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was that serde deserialize bug -- turns out if you bring a custom deserializer then the Option<T>
doesn't pick it up so you have to make it explicit
} | ||
|
||
#[test] | ||
fn verify() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aweomse!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 good stuff, looks good!
c52fe83
to
e0795cf
Compare
We need to first merge this PR decentralized-identity/web5-spec#173 and then update our web5-spec commitEdit: done