-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CLI binaries and attach them to release #330
Build CLI binaries and attach them to release #330
Conversation
e94027f
to
a43870a
Compare
just as a heads up, I just added a windows target build in #329 -- no need to make it part of this PR, but we should expect to add CLI support for Windows (but that may be multifaceted so can do later if it's excessive here) |
cargo build --target aarch64-apple-darwin --release --package web5_cli | ||
cp -v target/aarch64-apple-darwin/release/web5_cli web5_cli-aarch64-apple-darwin | ||
- name: upload release asset | ||
uses: AButler/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was thinking about using the GitHub native action for this, but looks like it's no longer maintained. however they do recommend this one https://github.com/softprops/action-gh-release. any thoughts on this vs the AButler one you have here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didnt see a way to use the AButler one to update an existing release. It wanted to be the one to create the release.
@finn-tbd any thoughts on adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few comments for discussion points, but this lgtm ✅
after we merge, could you try to utilize it in this repo? we're not strict on versioning right now, looks like 0.0.5 would be the next version
Co-authored-by: Kendall Weihe <[email protected]>
IMO we should not add |
@finn-tbd nice, yeah agreed! |
This adds GitHub Action jobs that build cli binaries when a release is created and attaches them to the release. You can see what this looks like on the latest test release in my branch. To use it, simply create a release and the automation will take care of the rest.