Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CLI binaries and attach them to release #330

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

finn-block
Copy link
Contributor

This adds GitHub Action jobs that build cli binaries when a release is created and attaches them to the release. You can see what this looks like on the latest test release in my branch. To use it, simply create a release and the automation will take care of the rest.

@KendallWeihe
Copy link
Contributor

just as a heads up, I just added a windows target build in #329 -- no need to make it part of this PR, but we should expect to add CLI support for Windows (but that may be multifaceted so can do later if it's excessive here)

cargo build --target aarch64-apple-darwin --release --package web5_cli
cp -v target/aarch64-apple-darwin/release/web5_cli web5_cli-aarch64-apple-darwin
- name: upload release asset
uses: AButler/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was thinking about using the GitHub native action for this, but looks like it's no longer maintained. however they do recommend this one https://github.com/softprops/action-gh-release. any thoughts on this vs the AButler one you have here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt see a way to use the AButler one to update an existing release. It wanted to be the one to create the release.

@KendallWeihe
Copy link
Contributor

@finn-tbd any thoughts on adding the install.sh script to the release assets? because then users can curl the releases URL for the install script

Copy link
Contributor

@KendallWeihe KendallWeihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments for discussion points, but this lgtm ✅

after we merge, could you try to utilize it in this repo? we're not strict on versioning right now, looks like 0.0.5 would be the next version

@finn-block
Copy link
Contributor Author

IMO we should not add install.sh to the release assets. We could post the curl .. | bash line in the release nodes ("to install or update, run...") but it seems kind of odd to post the same file over and over and if it changed. Also, install.sh will hopefully become brew install ... eventually

@finn-block finn-block merged commit caacb9a into decentralized-identity:main Aug 30, 2024
21 checks passed
@KendallWeihe
Copy link
Contributor

@finn-tbd nice, yeah agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants