Fix null pointer in VC verify #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 69.58% 69.92% +0.34%
==========================================
Files 21 21
Lines 1200 1197 -3
Branches 136 135 -1
==========================================
+ Hits 835 837 +2
+ Misses 294 292 -2
+ Partials 71 68 -3
|
mistermoe
reviewed
Oct 24, 2023
credentials/src/main/kotlin/web5/sdk/credentials/VerifiableCredential.kt
Show resolved
Hide resolved
credentials/src/main/kotlin/web5/sdk/credentials/VerifiableCredential.kt
Show resolved
Hide resolved
tomdaffurn
changed the title
phoebe-lew
approved these changes
Oct 25, 2023
phoebe-lew
added a commit
that referenced
this pull request
Oct 27, 2023
* main: (37 commits) refactor test payload generation fix payload generation in test simplify test change test name to be more descriptive Revert "add version hipster badge and usage instructions to README" add version hipster badge and usage instructions to README add TODO version bump appease detekt account for signatures less than 64 bytes Fix null pointer in VC verify (#94) Do also authentication by default. Apply suggestions from code review bump version to 0.0.6 updates Default ion creation sets assertion method (#93) Added more validation and tests Some fixes after testing Assertion method should be the default Better names ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix a null pointer that occurs when verifying a VC signed with an ION DID that has no assertionMethod
How Has This Been Tested?
New unit test added