fix serial/deserialization of presentation definitions #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebe-lew
requested review from
andresuribe87,
mistermoe,
nitro-neal and
tomdaffurn
as code owners
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 56.73% 61.55% +4.82%
==========================================
Files 20 20
Lines 832 822 -10
Branches 99 100 +1
==========================================
+ Hits 472 506 +34
+ Misses 313 269 -44
Partials 47 47
|
phoebe-lew
changed the title
tomdaffurn
approved these changes
Oct 20, 2023
|
|
||
| @Test | ||
| fun `can deserialize`() { | ||
| val pdString = """ |
There was a problem hiding this comment.
Would recommend splitting the json into a separate file.
| .setSerializationInclusion(JsonInclude.Include.NON_NULL) | ||
|
|
||
| @Test | ||
| fun `can serialize`() { |
There was a problem hiding this comment.
One additional test that I find very useful is around idempotency. See https://github.com/TBD54566975/web5-kt/blob/a8d10d9fa92226d2432dbb8fd85f9a46792bf5be/dids/src/test/kotlin/web5/sdk/dids/DidResolutionResultTest.kt#L13 for an example. It makes sure that data isn't lost in the round trip.
andresuribe87
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.