Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sign to bytes in / bytes out and finish out Secp256k1 im… #61

Merged
merged 11 commits into from
Oct 9, 2023

Conversation

mistermoe
Copy link
Contributor

TODO: Fill out

  • refactored sign to be bytes in / bytes out
  • finished out Secp256k1 implementation

@mistermoe mistermoe requested a review from tomdaffurn October 6, 2023 04:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #61 (26ae727) into main (20ee82c) will decrease coverage by 1.58%.
The diff coverage is 4.54%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   14.66%   13.09%   -1.58%     
==========================================
  Files          15       15              
  Lines         409      443      +34     
  Branches       51       54       +3     
==========================================
- Hits           60       58       -2     
- Misses        346      380      +34     
- Partials        3        5       +2     
Files Coverage Δ
...to/src/main/kotlin/web5/sdk/crypto/KeyGenerator.kt 0.00% <ø> (ø)
crypto/src/main/kotlin/web5/sdk/crypto/Signer.kt 0.00% <0.00%> (ø)
dids/src/main/kotlin/web5/sdk/dids/DidKey.kt 79.48% <40.00%> (-9.71%) ⬇️
crypto/src/main/kotlin/web5/sdk/crypto/Ed25519.kt 0.00% <0.00%> (ø)
crypto/src/main/kotlin/web5/sdk/crypto/Crypto.kt 0.00% <0.00%> (ø)
...rypto/src/main/kotlin/web5/sdk/crypto/Secp256k1.kt 0.00% <0.00%> (ø)

@mistermoe mistermoe linked an issue Oct 8, 2023 that may be closed by this pull request
crypto/src/main/kotlin/web5/sdk/crypto/Crypto.kt Outdated Show resolved Hide resolved
crypto/src/main/kotlin/web5/sdk/crypto/Crypto.kt Outdated Show resolved Hide resolved
crypto/src/main/kotlin/web5/sdk/crypto/Crypto.kt Outdated Show resolved Hide resolved
crypto/src/main/kotlin/web5/sdk/crypto/Secp256k1.kt Outdated Show resolved Hide resolved
crypto/src/main/kotlin/web5/sdk/crypto/Secp256k1.kt Outdated Show resolved Hide resolved
@mistermoe mistermoe marked this pull request as ready for review October 9, 2023 01:41
@mistermoe mistermoe requested a review from phoebe-lew October 9, 2023 01:45
Co-Authored-By: phoebe-lew <[email protected]>
@mistermoe mistermoe merged commit 723d2aa into main Oct 9, 2023
@mistermoe mistermoe deleted the secp256k1 branch October 9, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement key generation, signing, and verification for secp256k1
4 participants