Marks some deps as part of the API #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
mistermoe and
nitro-neal
as code owners
nitro-neal
reviewed
Sep 27, 2023
| @@ -331,7 +330,7 @@ private fun evaluateJsonPath(vcJwt: VcJwt, path: String): String? { | |||
| val vc: VerifiableCredentialType = | |||
| FromJwtConverter.fromJwtVerifiableCredential(JwtVerifiableCredential.fromCompactSerialization(vcJwt)) | |||
|
|
|||
| val vcJsonString: String = JSONValue.toJSONString(vc.jsonObject) | |||
| val vcJsonString: String = vc.toJson() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code that depends on
web5-sdk-kotlincurrently needs to pull dependencies that are part of public signatures. This PR fixes this.Description
For a more details description, see https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation
How Has This Been Tested?
Followed the instructions in a local repository which exercises full functionality.