Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to JsonWebKey #220

Closed
wants to merge 2 commits into from
Closed

Updating to JsonWebKey #220

wants to merge 2 commits into from

Conversation

nitro-neal
Copy link
Contributor

Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #220 (66319ac) into main (6305ad1) will increase coverage by 0.52%.
The diff coverage is 83.33%.

❗ Current head 66319ac differs from pull request most recent head 9e139b6. Consider uploading reports for the commit 9e139b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   79.62%   80.14%   +0.52%     
==========================================
  Files          38       37       -1     
  Lines        2189     2196       +7     
  Branches      316      310       -6     
==========================================
+ Hits         1743     1760      +17     
+ Misses        311      297      -14     
- Partials      135      139       +4     
Components Coverage Δ
credentials 82.21% <0.00%> (+0.06%) ⬆️
crypto 38.07% <ø> (-6.04%) ⬇️
dids 89.71% <100.00%> (-0.31%) ⬇️
common 80.55% <ø> (+11.59%) ⬆️

@jiyoonie9
Copy link
Contributor

jiyoonie9 commented Feb 8, 2024

@nitro-neal are we removing JsonWebKey2020 or also supporting JsonWebKey in addition? i asked about this in our internal slack and @frankhinek said we should support both for a while, so that's what my tbdex-kt PR had

slack thread with frank's comment here
my PR here

@nitro-neal
Copy link
Contributor Author

@jiyoontbd yup I'm getting this one in: #233 then once it works with jsonwebkey2020 and jsonwebkey I can merge this one in and it will work with both

@jiyoonie9
Copy link
Contributor

looks like this one can be merged now @nitro-neal ?

@nitro-neal
Copy link
Contributor Author

Closing as ion is going away and this will need a large refactor, will revisit in the future

@nitro-neal nitro-neal closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace JsonWebKey2020 with JsonWebKey
5 participants