Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Leak: decentralized-identity:did-common-java #231

Closed
ALRubinger opened this issue Feb 12, 2024 · 1 comment · Fixed by #248
Closed

API Leak: decentralized-identity:did-common-java #231

ALRubinger opened this issue Feb 12, 2024 · 1 comment · Fixed by #248
Assignees
@jiyoonie9
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ALRubinger
Copy link
Contributor

Submodule dids in web5-kt is exporting an api dependency:

  • api(libs.decentralizedIdentityDidCommonJava) > decentralized-identity:did-common-java

This means consumers are expected to use this dep directly. Encapsulate necessary operations in the web5-kt API such that we're not exposing the decentralized-identity APIs and asking users to rely on those. Our use internally should be an impl detail. Then move this to an implementation dependency.
@ALRubinger ALRubinger added enhancement New feature or request good first issue Good for newcomers labels Feb 12, 2024
@frankhinek
Copy link
Contributor

Will resolved by #185

@jiyoonie9 jiyoonie9 moved this to In Progress in SDK Development Feb 21, 2024
@jiyoonie9 jiyoonie9 linked a pull request Feb 21, 2024 that will close this issue
Removing did-common-java dependency #248
Merged
4 tasks
@jiyoonie9 jiyoonie9 self-assigned this Feb 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in SDK Development Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiyoonie9 jiyoonie9

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing did-common-java dependency decentralized-identity/web5-kt
3 participants
@frankhinek @ALRubinger @jiyoonie9