-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ok boolean to DWNResponseStatus #959
base: main
Are you sure you want to change the base?
feat: add ok boolean to DWNResponseStatus #959
Conversation
|
Hey @Toheeb-Ojuolape! Thanks for this! Great work, if you could add some tests that confirm the behavior that would be great! |
Hi @LiranCohen I've added some tests. Hope you find it acceptable. Thank you |
Hey @Toheeb-Ojuolape! Thanks for this, I'm seeing a few Type errors in the test runner for some reason, will pull it down in a bit to confirm myself. For the tests, would you mind creating it's own specific test for each interface that describes the behavior. That way it's easy to find the behavior of the specific test. As well as adding a negative test case (can be within the postiive one as well) to show it returning false. Something along the lines of `status ok boolean should be true if the response is ok'. |
What type of PR is this? (check all applicable)
Description
This PR adds an ok boolean to the DWNResponseStatus for requests that were successful
Related Tickets & Documents
Resolves #904
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
[optional] Are there any post-deployment tasks we need to perform?
Please run npm install or make sure @web5/crypto package is installed before testing
[optional] What gif best describes this PR or how it makes you feel?