-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IdentityApi
to be scoped to the agent as a tenant.
#911
Conversation
🦋 Changeset detectedLatest commit: c06a929 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-09-26T16:17:42Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
+ Coverage 93.44% 93.49% +0.05%
==========================================
Files 117 117
Lines 33470 33438 -32
Branches 2704 2705 +1
==========================================
- Hits 31277 31264 -13
+ Misses 2154 2135 -19
Partials 39 39
|
IdentityApi
to be scoped to the agent as a tenant.IdentityApi
to be scoped to the agent as a tenant.
…D in subsequent PR
When thinking about importing/syncing identities across wallets (or agents) there is a lot of extra complexity associated with the different tenants who store the identities.
Within this PR:
IdentityApi
to be agent-focused and storing both the DID and IdentityMetadata under the agent's tenant.manage
in IdentityApi.The DidApi remains unchanged and a default
did.create()
will store the DID document as the tenant of the newly created DID.In a subsequent PRs I would like to take some of the logic from
AgentDidResolverCache
and move it to the DidStore. That way not only agent DIDs but any DIDs which are imported int the DID store will be respected as long-term DIDs and the DID Store itself will be refreshed with updated DID doc information from resolution. As well as introduce anupdate
method to the DID / Identity APIs.