-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol Query with or without grant, Configure with grant. #894
Conversation
🦋 Changeset detectedLatest commit: 911aa96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-09-11T23:46:23Z |
14d2849
to
857782f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
- Coverage 93.45% 93.44% -0.02%
==========================================
Files 117 117
Lines 33408 33470 +62
Branches 2697 2704 +7
==========================================
+ Hits 31223 31277 +54
- Misses 2146 2154 +8
Partials 39 39
|
857782f
to
4603908
Compare
…or public protocols
…ermission is found
…tocol interface messages
e158029
to
79173c0
Compare
// ProtocolConfigure messages are also delegated, as they modify state | ||
return true; | ||
} | ||
|
||
// All other permissions are not treated as delegated | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests to cover these lines before merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go.
Permission
can now includeconfigure
which representsProtocolsConfigure
of a particular protocolcreatePermissionRequestForProtocol
now includes a grant forProtocolsQuery
for the protocol.