Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of tests that create new did:dht DIDs #860

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Aug 31, 2024

In several of the tests we were creating fresh did:dht identities before each test run.

In this PR most of the createIdentity() methods were moved into before instead of beforeEach and generating a new protocol URI on each run to differentiate counts, specifically on a remote.

Additionally some tests do not need a remote DWN at all, so a did:jwk was used.

Copy link

changeset-bot bot commented Aug 31, 2024

⚠️ No Changeset found

Latest commit: d7a08a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 31, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 5

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts
📄 File: ./packages/crypto/src/utils.ts
⚠️ extractor:typedoc:missing-docs: CryptoUtils (Variable) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomPin (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomUuid (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomBytes (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.getJoseSignatureAlgorithmFromPublicKey (Property) does not have any documentation.

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-08-31T07:08:41Z d7a08a4

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (9f08161) to head (d7a08a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #860   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         118      118           
  Lines       33134    33134           
  Branches     2649     2649           
=======================================
  Hits        30956    30956           
  Misses       2138     2138           
  Partials       40       40           
Components Coverage Δ
agent 87.46% <ø> (ø)
api 99.55% <ø> (ø)
common 98.68% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.79% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.42% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.42% <ø> (ø)
user-agent 96.44% <ø> (ø)

@LiranCohen LiranCohen marked this pull request as ready for review August 31, 2024 07:09
@LiranCohen LiranCohen merged commit d643160 into main Aug 31, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/records-test-single-did branch August 31, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants