Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI WebKit Tests #67

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix CI WebKit Tests #67

merged 2 commits into from
May 17, 2023

Conversation

frankhinek
Copy link
Contributor

Runs the browser tests using a macOS runner to ensure that Chromium, Firefox, and WebKit tests can all be executed.

@frankhinek frankhinek added the testing related to new or existing tests label May 17, 2023
@frankhinek frankhinek requested a review from mistermoe May 17, 2023 09:27
@frankhinek frankhinek self-assigned this May 17, 2023
@frankhinek frankhinek requested a review from csuwildcat as a code owner May 17, 2023 09:27
…ng test per project to avoid NPM errors

Signed-off-by: Frank Hinek <[email protected]>
@frankhinek frankhinek force-pushed the fix/gh-action-webkit branch from 8f5c011 to e3f3ab0 Compare May 17, 2023 09:30
@michaelneale
Copy link
Contributor

nice - any reason why it is macos-latest?

Copy link
Contributor

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@frankhinek
Copy link
Contributor Author

frankhinek commented May 17, 2023

nice - any reason why it is macos-latest?

To be able to run the WebKit browser tests. Chromium and Firefox available with the ubuntu-latest runner -- but WebKit is only on the macOS runners.

@frankhinek frankhinek merged commit bbbf2b0 into main May 17, 2023
@frankhinek frankhinek deleted the fix/gh-action-webkit branch May 17, 2023 13:24
@michaelneale
Copy link
Contributor

michaelneale commented May 18, 2023

@frankhinek oh it was macos instead of ubuntu that confused me (not latest) - that makes sense now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing related to new or existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants