Fixed DID DHT library regression where kid becomes undefined
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
csuwildcat,
diehuxx and
nitro-neal
as code owners
🦋 Changeset detectedLatest commit: 49a931e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nitro-neal
reviewed
May 16, 2024
| dnsPacket : dnsPacket | ||
| }); | ||
|
|
||
| expect(didResolutionResult.didDocument).to.deep.equal(inputDidDocument); |
thehenrytsai
requested review from
frankhinek,
mistermoe and
LiranCohen
as code owners
nitro-neal
reviewed
May 16, 2024
| @@ -1038,13 +1038,14 @@ export class DidDhtDocument { | |||
| publicKey.alg = parsedAlg || KeyTypeToDefaultAlgorithmMap[Number(t) as DidDhtRegisteredKeyType]; | |||
|
|
|||
| // Determine the Key ID (kid): '0' for the identity key or JWK thumbprint for others. | |||
| publicKey.kid = dnsRecordId.endsWith('0') ? '0' : await computeJwkThumbprint({ jwk: publicKey }); | |||
| const kid = dnsRecordId.endsWith('0') ? '0' : await computeJwkThumbprint({ jwk: publicKey }); | |||
| publicKey.kid = kid; | |||
|
|
|||
| // Initialize the `verificationMethod` array if it does not already exist. | |||
| didDocument.verificationMethod ??= []; | |||
|
|
|||
| // Prepend the DID URI to the ID fragment to form the full verification method ID. | |||
There was a problem hiding this comment.
What would you like me to update the comment to? I'll do it!
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-16T18:18:25Z |
Co-authored-by: Liran Cohen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 91.10% 91.12% +0.02%
==========================================
Files 116 116
Lines 29664 29665 +1
Branches 2199 2200 +1
==========================================
+ Hits 27024 27033 +9
+ Misses 2605 2597 -8
Partials 35 35
|
LiranCohen
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kidbecomesundefined