-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated c8 dependencies and add --no-frozen-lockfile flag in CI #551
Conversation
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-10T22:18:08Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to migrate us to biome. I think eslint 9 has severe breaking changes, are you sure it's worth our time?
Hey @shamilovtim, yeah... breaking change galore... though I used Biome looks freaking awesome especially given the recent deprecation development of eslint and the uptake for biome is through the roof. I'd be down to try it first in a more isolated repo ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 116 116
Lines 29603 29603
Branches 2185 2185
=======================================
Hits 26958 26958
Misses 2610 2610
Partials 35 35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
- Added --no-frozen-lockfile flag in CI workflows to allow dependabot to modify pnpm-lock.yaml. - Updated CODEOWNERS so tbdex dependent package has at least 2 approvers available for sign off with any given PR. - Updated c8 version across all packages.
--no-frozen-lockfile
flag in CI workflows to allow dependabot to modifypnpm-lock.yaml
c8
version across all packages.