Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated c8 dependencies and add --no-frozen-lockfile flag in CI #551

Merged
merged 5 commits into from
May 10, 2024

Conversation

thehenrytsai
Copy link
Contributor

@thehenrytsai thehenrytsai commented May 9, 2024

  1. Added --no-frozen-lockfile flag in CI workflows to allow dependabot to modify pnpm-lock.yaml
  2. Updated CODEOWNERS so tbdex dependent package has at least 2 approvers available for sign off with any given PR.
  3. Updated c8 version across all packages.

Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 1f22ba4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 9, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-05-10T22:18:08Z 1f22ba4

Copy link
Contributor

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to migrate us to biome. I think eslint 9 has severe breaking changes, are you sure it's worth our time?

@thehenrytsai thehenrytsai marked this pull request as draft May 10, 2024 17:08
@thehenrytsai
Copy link
Contributor Author

thehenrytsai commented May 10, 2024

Hey @shamilovtim, yeah... breaking change galore... though I used dwn-sdk-js as the guinea pig (decentralized-identity/dwn-sdk-js#737) and managed to make it work, and was painful. Though we do have a path forward now that we know what to do.

Biome looks freaking awesome especially given the recent deprecation development of eslint and the uptake for biome is through the roof.

I'd be down to try it first in a more isolated repo (dwn-sdk-js?) if you'd like to make that change (provided you can hit the milestones of other higher-pri work items), so that we are sure we love it before rolling it out web5-js wide. I am cautious seeing it 97% compatible with prettier as I disliked a lot on some very basic immutable rules of prettier, maybe those are the 3% they changed.

@thehenrytsai thehenrytsai changed the title Updated eslint version and add --no-frozen-lockfile flag in CI Updated c8 dependencies and add --no-frozen-lockfile flag in CI May 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (d6e128a) to head (1f22ba4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files         116      116           
  Lines       29603    29603           
  Branches     2185     2185           
=======================================
  Hits        26958    26958           
  Misses       2610     2610           
  Partials       35       35           
Components Coverage Δ
agent 80.70% <ø> (ø)
api 97.93% <ø> (ø)
common 98.68% <ø> (ø)
credentials 95.26% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.69% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@thehenrytsai thehenrytsai marked this pull request as ready for review May 10, 2024 22:01
shamilovtim
shamilovtim previously approved these changes May 10, 2024
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thehenrytsai thehenrytsai merged commit bd157de into main May 10, 2024
11 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/eslint-version branch May 10, 2024 22:52
nitro-neal pushed a commit that referenced this pull request May 13, 2024
- Added --no-frozen-lockfile flag in CI workflows to allow dependabot to modify pnpm-lock.yaml.
- Updated CODEOWNERS so tbdex dependent package has at least 2 approvers available for sign off with any given PR.
- Updated c8 version across all packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants